Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto yaml and other utils #27

Merged
merged 19 commits into from
Apr 30, 2022
Merged

auto yaml and other utils #27

merged 19 commits into from
Apr 30, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Apr 28, 2022

closes #11

The as_yaml_auto function, validation and conversion of a flat list (like shiny input) to the nested and proper one.

  • if many layers list then yaml::as.yaml directly
  • if a one layer list then we could assign fields automatically

why we need this as_yaml_auto function as shiny inputs return flat list
After this function is established we could introduce custom yaml header fields in the Download Modules
#26

Other helpful yaml utils were added.

@Polkas Polkas marked this pull request as ready for review April 28, 2022 11:36
Copy link
Contributor

@nikolas-burkoff nikolas-burkoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments from me - I've certainly not done a full review

R/yaml_utils.R Outdated Show resolved Hide resolved
R/yaml_utils.R Outdated Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Unit Tests Summary

    1 files    13 suites   7s ⏱️
126 tests 126 ✔️ 0 💤 0
170 runs  170 ✔️ 0 💤 0

Results for commit a2d7d6d.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 28, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------
R/AddCardModule.R        75       3  96.00%   53-55
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      134       5  96.27%   77-79, 100, 154
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         31       0  100.00%
R/Renderer.R             54       8  85.19%   142, 144-145, 155-157, 164, 166
R/ReportCard.R           43       0  100.00%
R/Reporter.R             17       0  100.00%
R/SimpleReporter.R       12       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TealReportCard.R        9       0  100.00%
R/TextBlock.R             7       0  100.00%
R/yaml_utils.R           74       2  97.30%   66, 265
TOTAL                   483      18  96.27%

Results for commit: 6047740

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

R/yaml_utils.R Outdated Show resolved Hide resolved
@Polkas
Copy link
Contributor Author

Polkas commented Apr 29, 2022

I just apply the function in the Download module

Polkas and others added 2 commits April 30, 2022 11:57
@Polkas Polkas merged commit 272347d into main Apr 30, 2022
@Polkas Polkas deleted the 11_yaml@main branch April 30, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rmd header - inputs  to yaml
4 participants