Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

898 save app state version 3 #268

Merged
merged 16 commits into from
Mar 28, 2024
Merged

898 save app state version 3 #268

merged 16 commits into from
Mar 28, 2024

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Mar 20, 2024

Companion to insightsengineering/teal#1011
Introduces bookmarking of report cards.

Copy link
Contributor

github-actions bot commented Mar 20, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/AddCardModule.R       146       2  98.63%   170, 207
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         18       2  88.89%   57-63
R/DownloadModule.R      207      49  76.33%   98-104, 147, 178-183, 192-196, 199-203, 211-215, 218-222, 229-233, 236-240, 279-283
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       2  93.33%   20, 118
R/Previewer.R           303      58  80.86%   87, 90, 209, 224, 226-229, 232, 235-243, 357-401
R/RcodeBlock.R           15       0  100.00%
R/Renderer.R            113      37  67.26%   97-112, 216, 224, 233, 235-256
R/ReportCard.R           77       4  94.81%   192, 233, 238, 259
R/Reporter.R             94       1  98.94%   270
R/ResetModule.R          53       0  100.00%
R/SimpleReporter.R       30       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R               171      80  53.22%   7, 38-97, 99, 102-109, 167, 179-181, 285-294
R/yaml_utils.R           81       2  97.53%   78, 289
R/zzz.R                  14      10  28.57%   2-13, 19
TOTAL                  1414     247  82.53%

Diff against main

Filename              Stmts    Miss  Cover
------------------  -------  ------  --------
R/AddCardModule.R        +2       0  +0.02%
R/DownloadModule.R       -2       0  -0.23%
R/Previewer.R            +6      +2  -0.29%
R/ResetModule.R          -2       0  +100.00%
TOTAL                    +4      +2  -0.09%

Results for commit: 5fb9e3b

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 20, 2024

Unit Tests Summary

  1 files   18 suites   12s ⏱️
204 tests 204 ✅ 0 💤 0 ❌
346 runs  346 ✅ 0 💤 0 ❌

Results for commit 5fb9e3b.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change could be independent of teal. Works well 👍

@gogonzo gogonzo self-assigned this Mar 21, 2024
@Polkas
Copy link
Contributor

Polkas commented Mar 25, 2024

I got some unexpected add card reactivity:(

Screen.Recording.2024-03-26.at.12.13.27.AM.mov

@chlebowa
Copy link
Contributor Author

This is expected and will be dealt with shortly.

@chlebowa chlebowa merged commit 3f301ca into main Mar 28, 2024
24 checks passed
@chlebowa chlebowa deleted the 898_save_app_state3@main branch March 28, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants