Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

238 bring back internal examples #239

Merged
merged 14 commits into from
Jan 18, 2024
Merged

238 bring back internal examples #239

merged 14 commits into from
Jan 18, 2024

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jan 16, 2024

Close #238

Examples moved to dev/ folder during #209 were brough back to their places. We substituted ::: usage, that is discouraged by CRAN, with getFromNamespace() function

@m7pr m7pr added the core label Jan 16, 2024
@m7pr m7pr requested a review from chlebowa January 16, 2024 10:38
Copy link
Contributor

github-actions bot commented Jan 16, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -----------------------------------------------------------------------------------
R/AddCardModule.R       144       2  98.61%   162, 199
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         18       2  88.89%   52-58
R/DownloadModule.R      207      49  76.33%   95-101, 143, 168-173, 182-186, 189-193, 201-205, 208-212, 219-223, 226-230, 267-271
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       2  93.33%   15, 109
R/Previewer.R           295      56  81.02%   188, 202, 204-207, 210, 213-221, 330-374
R/RcodeBlock.R           15       0  100.00%
R/Renderer.R            113      37  67.26%   87-102, 203, 211, 220, 222-243
R/ReportCard.R           77       4  94.81%   181, 220, 225, 246
R/Reporter.R             94       1  98.94%   254
R/ResetModule.R          55       0  100.00%
R/SimpleReporter.R       30       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R               171      80  53.22%   7, 38-97, 99, 102-109, 163, 175-177, 287-296
R/yaml_utils.R           81       2  97.53%   70, 268
R/zzz.R                  14      10  28.57%   2-13, 19
TOTAL                  1406     245  82.57%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 0061ffe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 16, 2024

Unit Tests Summary

  1 files   18 suites   12s ⏱️
204 tests 204 ✅ 0 💤 0 ❌
346 runs  346 ✅ 0 💤 0 ❌

Results for commit 0061ffe.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if $initialize methods that take no arguments really require examples.

R/Archiver.R Outdated Show resolved Hide resolved
@m7pr m7pr requested a review from chlebowa January 17, 2024 12:24
R/Archiver.R Outdated Show resolved Hide resolved
@m7pr m7pr requested a review from chlebowa January 17, 2024 14:50
@m7pr m7pr merged commit 69fc438 into main Jan 18, 2024
24 checks passed
@m7pr m7pr deleted the 238_internal_examples@main branch January 18, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move internal examples from dev/ folder into regular R/*.R files and use getFromNamespace() instead of :::
2 participants