Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

init simple report #23

Merged
merged 51 commits into from
Apr 29, 2022
Merged

init simple report #23

merged 51 commits into from
Apr 29, 2022

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Apr 20, 2022

closes #1
closes #12
closes #13

  • 3 shiny Modules added: downlaod_reporter_button_srv, add_card_button_srv and simple_reporter_srv (combine two previous ones).
  • Full coverage of code in tests.

Possible controversial point is that in the shiny apps we will recommend, such code:

  card_r <- eventReactive(
    teal.reporter::extract_addcard_input(input), {

teal.reporter::extract_addcard_input is looking for an id with a suffix "addReportCardButton$". So there is very very small probability of id collision. I prefer to have it readable as sb might want to use it directly, without usage of teal.reporter::extract_addcard_id. teal.reporter::extract_addcard_input(input) requires an active reactive context, and eventExpr argument is such.

Fo the previewer task we need another download module as we need a custom UI and does not need a modal. Most of the code from downlaod_reporter_button_* module could be reused.
I expected some small updates when introducing for TEAL.

@Polkas Polkas marked this pull request as ready for review April 22, 2022 08:07
@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------
R/AddCardModule.R        75       3  96.00%   53-55
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      141       5  96.45%   77-79, 100, 154
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         31       0  100.00%
R/Renderer.R             54       8  85.19%   142, 144-145, 155-157, 164, 166
R/ReportCard.R           43       0  100.00%
R/Reporter.R             17       0  100.00%
R/SimpleReporter.R       12       0  100.00%
R/TableBlock.R            9       0  100.00%
R/TealReportCard.R        9       0  100.00%
R/TextBlock.R             7       0  100.00%
R/yaml_utils.R            3       0  100.00%
TOTAL                   419      16  96.18%

Results for commit: af777ee

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

github-actions bot commented Apr 22, 2022

Unit Tests Summary

    1 files    13 suites   6s ⏱️
110 tests 110 ✔️ 0 💤 0
135 runs  135 ✔️ 0 💤 0

Results for commit a7702f3.

♻️ This comment has been updated with latest results.

@Polkas Polkas requested a review from kpagacz April 22, 2022 08:21
R/AddCardModule.R Outdated Show resolved Hide resolved
@kpagacz kpagacz self-assigned this Apr 26, 2022
R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/DownloadModule.R Outdated Show resolved Hide resolved
vignettes/simpleReporter.Rmd Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/AddCardModule.R Outdated Show resolved Hide resolved
R/SimpleReporter.R Outdated Show resolved Hide resolved
vignettes/simpleReporter.Rmd Outdated Show resolved Hide resolved
tests/testthat/test-SimpleReporter.R Outdated Show resolved Hide resolved
Copy link
Contributor

@mhallal1 mhallal1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comments and good to go.

@Polkas Polkas merged commit 31f0da9 into main Apr 29, 2022
@Polkas Polkas deleted the 1_simple_app@main branch April 29, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants