-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init simple report #23
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Summary
Results for commit: af777ee Minimum allowed coverage is ♻️ This comment has been updated with latest results |
mhallal1
reviewed
Apr 26, 2022
mhallal1
reviewed
Apr 26, 2022
Co-authored-by: Konrad Pagacz <[email protected]> Co-authored-by: Mahmoud Hallal <[email protected]>
mhallal1
reviewed
Apr 29, 2022
mhallal1
reviewed
Apr 29, 2022
kpagacz
reviewed
Apr 29, 2022
Co-authored-by: Mahmoud Hallal <[email protected]>
Polkas
commented
Apr 29, 2022
kpagacz
approved these changes
Apr 29, 2022
mhallal1
reviewed
Apr 29, 2022
mhallal1
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comments and good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1
closes #12
closes #13
downlaod_reporter_button_srv
,add_card_button_srv
andsimple_reporter_srv
(combine two previous ones).Possible controversial point is that in the shiny apps we will recommend, such code:
teal.reporter::extract_addcard_input
is looking for an id with a suffix "addReportCardButton$". So there is very very small probability of id collision. I prefer to have it readable as sb might want to use it directly, without usage ofteal.reporter::extract_addcard_id
.teal.reporter::extract_addcard_input(input)
requires an active reactive context, andeventExpr
argument is such.Fo the previewer task we need another download module as we need a custom UI and does not need a modal. Most of the code from
downlaod_reporter_button_*
module could be reused.I expected some small updates when introducing for TEAL.