-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
185 fixing table formatting in PPT outputs #211
Conversation
Merge branch 'main' into 185_fixing_formating@main # Conflicts: # DESCRIPTION
Code Coverage Summary
Diff against main
Results for commit: 214841d Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Merge branch '185_fixing_formating@main' of https://github.com/insightsengineering/teal.reporter into 185_fixing_formating@main # Conflicts: # man/to_flextable.Rd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @kartikeyakirar 💯
Feature-wise it performs very well! I found no issues when testing against cards that contained a table or table + plot
(see screenshot below)
It works with {teal.gallery} longitudinal app and a bunch of others.
I have some comments on the code that I think would help with the readability of the code for "future us" 😅
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, great work @kartikeyakirar 🎉
2 small (last) suggestions to keep up with test naming convention. Feel free to merge after 😁
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
I have addressed the requested modifications to resolve the issue of the table not appearing in the preview. However, the request still remains in the checklist. @gogonzo , I will submit another pull request if further changes are necessary.
this PR fixes #185
Inspired by autoslidR, I have integrated flextable functionality to convert "data.frame," "rtables," "TableTree," and "ElementaryTable" into flextable, which offers a more accurate representation. In this context, I have enhanced the TableBlock to facilitate the conversion of tables into flextable.
Output screenshot