Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Renderer.R #148

Closed
wants to merge 2 commits into from
Closed

Update Renderer.R #148

wants to merge 2 commits into from

Conversation

Polkas
Copy link
Contributor

@Polkas Polkas commented Oct 10, 2022

closes #147

Not the height of the plot will be taken in to account too when it is rendered.

Please render any html document and check the img tag that now it contains both height and width.

image

Signed-off-by: Maciej Nasinski <[email protected]>
@Polkas Polkas added the core label Oct 10, 2022
Signed-off-by: Maciej Nasinski <[email protected]>
@github-actions
Copy link
Contributor

Unit Tests Summary

    1 files    18 suites   8s ⏱️
193 tests 193 ✔️ 0 💤 0
280 runs  280 ✔️ 0 💤 0

Results for commit eb2a85b.

@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  --------------------------------------------------------------------
R/AddCardModule.R       101       0  100.00%
R/Archiver.R             25       0  100.00%
R/ContentBlock.R         16       0  100.00%
R/DownloadModule.R      169      43  74.56%   84-90, 159-164, 173-177, 180-184, 192-196, 199-203, 210-214, 217-221
R/FileBlock.R            13       0  100.00%
R/NewpageBlock.R          2       0  100.00%
R/PictureBlock.R         30       1  96.67%   15
R/Previewer.R           262      52  80.15%   164, 166-169, 174-180, 305-349
R/Renderer.R             54       4  92.59%   142, 144-145, 166
R/ReportCard.R           76       2  97.37%   211, 232
R/Reporter.R             96       1  98.96%   255
R/ResetModule.R          55       0  100.00%
R/SimpleReporter.R       24       0  100.00%
R/TableBlock.R            8       0  100.00%
R/TealReportCard.R       28       0  100.00%
R/TextBlock.R            13       0  100.00%
R/utils.R                 4       1  75.00%   7
R/yaml_utils.R           74       2  97.30%   65, 263
TOTAL                  1050     106  89.90%

Results for commit: 739602d

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@mhallal1 mhallal1 assigned mhallal1 and unassigned mhallal1 Oct 10, 2022
@Polkas
Copy link
Contributor Author

Polkas commented Oct 10, 2022

this fix the html but broken the pdf one.

@Polkas Polkas closed this Oct 10, 2022
@insights-engineering-bot insights-engineering-bot deleted the 147_img_height@main branch July 2, 2023 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reporter: table resizing issue
2 participants