Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reporter: table resizing issue #147

Open
Tracked by #44
BLAZEWIM opened this issue Oct 5, 2022 · 6 comments
Open
Tracked by #44

Reporter: table resizing issue #147

BLAZEWIM opened this issue Oct 5, 2022 · 6 comments
Labels

Comments

@BLAZEWIM
Copy link

BLAZEWIM commented Oct 5, 2022

Even when the table is resized to look nice in the UI, its resizing in reporter is not exactly matched.

It can be seen best on this example:

Steps:

  1. Run:
example(tm_g_forest_rsp, package = 'teal.modules.clinical')
shinyApp(app$ui, app$server)
  1. Go to resize button, Disable Auto width and set plot width to maximum. Add card to reporter.

image

image

  1. In reporter preview, plot is almost fine (labels overlap). Click Download report (html).
    image

  2. File is almost fine (labels overlap) when opened directly from .png in the downloaded folder.
    image

  3. Plot is corrupted when opened in html:
    image

@mhallal1
Copy link
Contributor

mhallal1 commented Oct 6, 2022

please give a reproducible example

@BLAZEWIM
Copy link
Author

BLAZEWIM commented Oct 6, 2022

please give a reproducible example

info edited

@mhallal1
Copy link
Contributor

mhallal1 commented Oct 6, 2022

The issue here is that the table overflows out its territory:
Screenshot from 2022-10-06 14-01-12

@donyunardi
Copy link
Contributor

donyunardi commented Oct 7, 2022

Added to the report generator enhancement roadmap which we will tackle next increment.
Move to backlog.

@Polkas
Copy link
Contributor

Polkas commented Oct 10, 2022

So I could not reproduce that the plot is wrongly formatted in the previewer.
However it is true for the html document.
@mhallal1 please create a separate issue if you see such.

@Polkas Polkas transferred this issue from insightsengineering/teal.modules.clinical Oct 10, 2022
@Polkas Polkas assigned Polkas and unassigned Polkas Oct 10, 2022
@asbates
Copy link
Contributor

asbates commented Oct 10, 2022

Added to the report generator enhancement roadmap which we will tackle next increment. Move to backlog.

@donyunardi I removed this from the current (UAT) sprint. Please correct me if this is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants