Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52 standardise optional notation #260

Merged
merged 15 commits into from
Mar 14, 2024
Merged

Conversation

kartikeyakirar
Copy link
Contributor

part of insightsengineering/nestdevs-tasks#52

  • standardise optional notation
  • updated roxygen tags

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Unit Tests Summary

 1 files   1 suites   0s ⏱️
 4 tests  4 ✅ 0 💤 0 ❌
13 runs  13 ✅ 0 💤 0 ❌

Results for commit 12ffdfa.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             252     252  0.00%    83-368
R/tm_g_ae_sub.R               315     315  0.00%    59-410
R/tm_g_butterfly.R            388     388  0.00%    124-552
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       299     299  0.00%    63-400
R/tm_g_heat_bygrade.R         322     322  0.00%    135-493
R/tm_g_patient_profile.R      711     711  0.00%    157-933
R/tm_g_spiderplot.R           324     324  0.00%    99-468
R/tm_g_swimlane.R             376     376  0.00%    124-557
R/tm_g_waterfall.R            427     427  0.00%    108-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         1       1  0.00%    2
TOTAL                        3498    3493  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 12ffdfa

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@m7pr m7pr self-assigned this Mar 14, 2024
R/utils.R Outdated Show resolved Hide resolved
R/utils.R Outdated Show resolved Hide resolved
R/tm_g_heat_bygrade.R Outdated Show resolved Hide resolved
Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, added a couple of cleanups to README, DESCRIPTION and R/teal.osprey.R then were overdue. Those would be required anyway.

Other than that this is ready to be merged. Great job.

kartikeyakirar and others added 4 commits March 14, 2024 16:54
@kartikeyakirar
Copy link
Contributor Author

@m7pr document inherit description from teal.widgets. so this needs to be merged and re-triggered checks after insightsengineering/teal.widgets#231 is merged.

@m7pr
Copy link
Contributor

m7pr commented Mar 14, 2024

Yes, I noticed. Feel free to merge insightsengineering/teal.widgets#231
then rebuild docs in here. And then merge this one.

@kartikeyakirar kartikeyakirar merged commit 63abc2a into main Mar 14, 2024
25 checks passed
@kartikeyakirar kartikeyakirar deleted the 52_standardise_optional@main branch March 14, 2024 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants