-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
52 standardise optional notation #260
Conversation
Unit Tests Summary 1 files 1 suites 0s ⏱️ Results for commit 12ffdfa. ♻️ This comment has been updated with latest results. |
Code Coverage Summary
Diff against main
Results for commit: 12ffdfa Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
…ightsengineering/teal.osprey into 52_standardise_optional@main
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, added a couple of cleanups to README, DESCRIPTION and R/teal.osprey.R then were overdue. Those would be required anyway.
Other than that this is ready to be merged. Great job.
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
Co-authored-by: Marcin <[email protected]> Signed-off-by: kartikeya kirar <[email protected]>
@m7pr document inherit description from teal.widgets. so this needs to be merged and re-triggered checks after insightsengineering/teal.widgets#231 is merged. |
Yes, I noticed. Feel free to merge insightsengineering/teal.widgets#231 |
part of insightsengineering/nestdevs-tasks#52