Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

214 review documentation after chunks->qenv transition #216

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Jul 13, 2023

This closes #204

@gogonzo there is one example that fails - #215 - besides that they all run fine. There is no teal.code::chunks narration exposed in examples nor vignettes. Also the teal.code was already at 0.3.0 so no need to update DESCRIPTION file. I don't think I am able to resolve #215 even though I tried a couple of times.

@m7pr m7pr added documentation Improvements or additions to documentation core labels Jul 13, 2023
@m7pr m7pr requested a review from gogonzo July 13, 2023 12:26
@github-actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                    Stmts    Miss  Cover    Missing
------------------------  -------  ------  -------  --------------
R/tm_g_ae_oview.R             247     247  0.00%    108-388
R/tm_g_ae_sub.R               316     316  0.00%    56-408
R/tm_g_butterfly.R            385     385  0.00%    135-560
R/tm_g_decorate.R              46      46  0.00%    18-98
R/tm_g_events_term_id.R       296     296  0.00%    62-396
R/tm_g_heat_bygrade.R         318     318  0.00%    161-514
R/tm_g_patient_profile.R      708     708  0.00%    197-970
R/tm_g_spiderplot.R           321     321  0.00%    103-469
R/tm_g_swimlane.R             375     375  0.00%    129-561
R/tm_g_waterfall.R            422     422  0.00%    113-586
R/utils.R                      37      32  13.51%   32-91, 124-131
R/zzz.R                         1       1  0.00%    2
TOTAL                        3472    3467  0.14%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: dfd70e1

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions
Copy link
Contributor

Unit Tests Summary

  1 files    1 suites   0s ⏱️
  4 tests   4 ✔️ 0 💤 0
13 runs  13 ✔️ 0 💤 0

Results for commit 35e8092.

@m7pr m7pr merged commit fc77915 into main Jul 13, 2023
@m7pr m7pr deleted the 204_review_documentation@main branch July 13, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: improper example for tm_g_swimlane Review tosprey documentation before release
2 participants