Skip to content

Commit

Permalink
added action button to prevent re-render upon incomplete inputs (#249)
Browse files Browse the repository at this point in the history
* added action button to prevent re-render upon incomplete inputs

* used debounce

* Update NEWS.md

* Update R/tm_g_swimlane.R

Co-Authored-By: Pagacz, Konrad {FIEV~Warsaw} <[email protected]>

* Update R/tm_g_swimlane.R

* Update R/tm_g_swimlane.R

* Update R/tm_g_swimlane.R

* Update NEWS.md

Co-authored-by: Junlue Zhao <[email protected]>
Co-authored-by: Pagacz, Konrad {FIEV~Warsaw} <[email protected]>
  • Loading branch information
3 people authored and GitHub Enterprise committed Jun 30, 2021
1 parent 600a96e commit 72f9416
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
# teal.osprey 0.1.10

### Enhancements
* Added a Shiny feature to `tm_g_swimlane` that will prevent needless re-render of the output when the user has not completely provided inputs to the vertical lines widget.

### Miscellaneous
* Altered the `Choose Up To 2:` inputs widget from the Encoding Panel to be independent of the Filtering Panel in `tm_g_butterfly`.
* Updated warning message when Tumor Burden Parameter is not selected in `tm_g_waterfall`.
Expand Down
2 changes: 1 addition & 1 deletion R/tm_g_swimlane.R
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ srv_g_swimlane <- function(input, output, session, datasets, dataname,
anno_txt_var <- input$anno_txt_var

# If reference lines are requested
vref_line <- as_numeric_from_comma_sep_str(input$vref_line)
vref_line <- as_numeric_from_comma_sep_str(debounce(reactive(input$vref_line), 1500)())
validate(need(all(!is.na(vref_line)),
"Please enter a comma separated set of numeric values for the reference line(s)"))

Expand Down

0 comments on commit 72f9416

Please sign in to comment.