Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

87 remove datasets - decrease package size #396

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Dec 13, 2024

In the spirit of package size reduction insightsengineering/nestdevs-tasks#87
I replaced all the calls for tmg datasets with their respective datasets from teal.data.
This way we no longer need to have datasets copies in tmg.

@m7pr m7pr added the core label Dec 13, 2024
@m7pr m7pr requested a review from llrs-roche December 13, 2024 10:32
Copy link
Contributor

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           171     124  27.49%   256-404
R/assaySpec.R            54      40  25.93%   104-147
R/barplot.R             188     152  19.15%   39-66, 129-280
R/boxplot.R             190     159  16.32%   40-67, 125-279
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       91      58  36.26%   97, 215-284
R/forestplot.R          214     186  13.08%   60-94, 154-329
R/geneSpec.R            257     154  40.08%   154-169, 296-481
R/km.R                  208     174  16.35%   63-94, 158-328
R/pca.R                 367     284  22.62%   34-56, 165-477
R/quality.R             320     247  22.81%   18-110, 208-454
R/sampleVarSpec.R       237     104  56.12%   300, 319-328, 334-341, 343, 351-363, 365-366, 368, 371, 379-383, 385-400, 405-429, 432-436, 438, 445-455, 457-458, 466, 511-528
R/scatterplot.R         181     148  18.23%   39-65, 127-273
R/utils.R                16       0  100.00%
R/volcanoplot.R         204     174  14.71%   34-57, 113-293
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2718    2015  25.86%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: be7d89e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 13, 2024

Unit Tests Summary

 1 files  15 suites   9s ⏱️
56 tests 43 ✅ 13 💤 0 ❌
94 runs  81 ✅ 13 💤 0 ❌

Results for commit be7d89e.

♻️ This comment has been updated with latest results.

Copy link

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I couldn't check this locally (problems from the proxy to connect to Bioconductor to install dependencies) but the changes look good

@m7pr m7pr merged commit 3d07127 into main Dec 13, 2024
28 of 29 checks passed
@m7pr m7pr deleted the 87_remove_datasets@main branch December 13, 2024 13:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants