Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

553 change level in log_shiny_input_changes and exclude plot sizes in logging #386

Merged
merged 16 commits into from
Jun 19, 2024

Conversation

@m7pr m7pr added the core label Jun 13, 2024
@m7pr m7pr requested a review from danielinteractive June 13, 2024 11:57
@m7pr
Copy link
Contributor Author

m7pr commented Jun 13, 2024

@danielinteractive just a small followup after #382

Changes:

  • we changed logging level from INFO to TRACE
  • we do not record changes in plots sizes when the app is resized in the browser window

To see logs about shiny input changes you need to run options(teal.log_level = "TRACE") before you run library(teal.modules.hermes).

Copy link
Contributor

github-actions bot commented Jun 13, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           171     124  27.49%   253-401
R/assaySpec.R            54      40  25.93%   104-147
R/barplot.R             188     152  19.15%   39-66, 129-280
R/boxplot.R             190     159  16.32%   40-67, 125-279
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       91      58  36.26%   97, 215-284
R/forestplot.R          214     186  13.08%   58-92, 152-327
R/geneSpec.R            257     154  40.08%   154-169, 296-481
R/km.R                  208     174  16.35%   61-92, 156-326
R/pca.R                 367     284  22.62%   34-56, 165-477
R/quality.R             320     247  22.81%   18-110, 208-454
R/sampleVarSpec.R       237     104  56.12%   300, 319-328, 334-341, 343, 351-363, 365-366, 368, 371, 379-383, 385-400, 405-429, 432-436, 438, 445-455, 457-458, 466, 511-528
R/scatterplot.R         181     148  18.23%   39-65, 127-273
R/utils.R                16       0  100.00%
R/volcanoplot.R         204     174  14.71%   34-57, 113-293
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2718    2015  25.86%

Diff against main

Filename             Stmts    Miss  Cover
-----------------  -------  ------  -------
R/sampleVarSpec.R        0      -1  +0.42%
TOTAL                    0      -1  +0.04%

Results for commit: dc551f6

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 13, 2024

Unit Tests Summary

 1 files  15 suites   8s ⏱️
56 tests 43 ✅ 13 💤 0 ❌
94 runs  81 ✅ 13 💤 0 ❌

Results for commit dc551f6.

♻️ This comment has been updated with latest results.

Signed-off-by: Marcin <133694481+m7pr@users.noreply.github.com>
@m7pr m7pr enabled auto-merge (squash) June 19, 2024 10:04
@m7pr m7pr merged commit 471902b into main Jun 19, 2024
29 of 30 checks passed
@m7pr m7pr deleted the 553_log_shiny_input_changes@main branch June 19, 2024 12:47
@github-actions github-actions bot locked and limited conversation to collaborators Jun 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants