Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add idling time #384

Merged
merged 2 commits into from
Jun 10, 2024
Merged

add idling time #384

merged 2 commits into from
Jun 10, 2024

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Jun 6, 2024

Increase timeout

══ Failed tests ════════════════════════════════════════════════════════════════
  ── Error ('test-adtteSpec.R:229:3'): adtteSpecServer module works as expected in the test app ──
  Error in `app_wait_for_idle(self, private, duration = duration, timeout = timeout)`: An error occurred while waiting for Shiny to be stable
  Backtrace:
      ▆
   1. └─app$wait_for_idle() at test-adtteSpec.R:229:3
   2.   └─shinytest2:::app_wait_for_idle(self, private, duration = duration, timeout = timeout)
   3.     └─shinytest2:::app_abort(self, private, "An error occurred while waiting for Shiny to be stable")
   4.       └─rlang::abort(..., app = self, call = call)
  ── Failure ('test-assaySpec.R:39:3'): assaySpecServer module works as expected in the test app ──
  res$message (`actual`) not identical to "No assays eligible for this experiment, please make sure to add normalized assays" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('No assays eligible for this experiment, please make sure to add normalized assays')
  ── Failure ('test-assaySpec.R:46:3'): assaySpecServer module works as expected in the test app ──
  `res` (`actual`) not identical to "rpkm" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('rpkm')
  ── Failure ('test-assaySpec.R:49:3'): assaySpecServer module works as expected in the test app ──
  `res` (`actual`) not identical to "[1] \"rpkm\"" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('[1] "rpkm"')
  ── Failure ('test-assaySpec.R:54:3'): assaySpecServer module works as expected in the test app ──
  `res` (`actual`) not identical to "[1] \"voom\"" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('[1] "voom"')
  ── Failure ('test-assaySpec.R:60:3'): assaySpecServer module works as expected in the test app ──
  `res` (`actual`) not identical to "[1] \"\"" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('[1] ""')
  ── Error ('test-pca.R:66:3'): pca module works as expected in the test app ─────
  Error in `app_wait_for_idle(self, private, duration = duration, timeout = timeout)`: An error occurred while waiting for Shiny to be stable
  Backtrace:
      ▆
   1. └─app$wait_for_idle() at test-pca.R:66:3
   2.   └─shinytest2:::app_wait_for_idle(self, private, duration = duration, timeout = timeout)
   3.     └─shinytest2:::app_abort(self, private, "An error occurred while waiting for Shiny to be stable")
   4.       └─rlang::abort(..., app = self, call = call)
  ── Failure ('test-scatterplot.R:72:3'): scatterplot module works as expected in the test app ──
  `res` (`actual`) not identical to "GeneID:503538" (`expected`).
  
  `actual` is NULL
  `expected` is a character vector ('GeneID:503538')
  ── Error ('test-scatterplot.R:78:3'): scatterplot module works as expected in the test app ──
  Error in `app_wait_for_idle(self, private, duration = duration, timeout = timeout)`: An error occurred while waiting for Shiny to be stable
  Backtrace:
      ▆
   1. └─app$wait_for_idle() at test-scatterplot.R:78:3
   2.   └─shinytest2:::app_wait_for_idle(self, private, duration = duration, timeout = timeout)
   3.     └─shinytest2:::app_abort(self, private, "An error occurred while waiting for Shiny to be stable")
   4.       └─rlang::abort(..., app = self, call = call)
  
  [ FAIL 9 | WARN 0 | SKIP 0 | PASS 171 ]

@danielinteractive danielinteractive marked this pull request as ready for review June 6, 2024 13:08
Copy link
Contributor

github-actions bot commented Jun 6, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  ------------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           171     124  27.49%   253-401
R/assaySpec.R            54      40  25.93%   104-147
R/barplot.R             188     152  19.15%   39-66, 129-280
R/boxplot.R             190     159  16.32%   40-67, 125-279
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       91      58  36.26%   97, 215-284
R/forestplot.R          214     186  13.08%   58-92, 152-327
R/geneSpec.R            257     154  40.08%   154-169, 296-481
R/km.R                  208     174  16.35%   61-92, 156-326
R/pca.R                 367     284  22.62%   34-56, 165-477
R/quality.R             320     247  22.81%   18-110, 208-454
R/sampleVarSpec.R       237     105  55.70%   291, 300, 319-328, 334-341, 343, 351-363, 365-366, 368, 371, 379-383, 385-400, 405-429, 432-436, 438, 445-455, 457-458, 466, 511-528
R/scatterplot.R         181     148  18.23%   39-65, 127-273
R/utils.R                16       0  100.00%
R/volcanoplot.R         204     174  14.71%   34-57, 113-293
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2718    2016  25.83%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 426f29e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Unit Tests Summary

 1 files  15 suites   8s ⏱️
56 tests 43 ✅ 13 💤 0 ❌
94 runs  81 ✅ 13 💤 0 ❌

Results for commit 426f29e.

♻️ This comment has been updated with latest results.

@BFalquet BFalquet merged commit 273ef72 into main Jun 10, 2024
25 of 26 checks passed
@BFalquet BFalquet deleted the fix_integration_test@main branch June 10, 2024 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants