Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

360 [Bug]: unexpected reinitialization #362

Merged
merged 6 commits into from
Feb 21, 2024

Conversation

BFalquet
Copy link
Contributor

@BFalquet BFalquet commented Feb 20, 2024

#360

close #360

  • add isolate to prevent the reinitialization of the UI upon filtering
  • split the input setting to avoid reproducibility issue (still not sure why)
  • add a sub test to ensure that modifying filter doesn't cause the UI to re-initialize

thank you for the review

Copy link
Contributor

github-actions bot commented Feb 20, 2024

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           170     123  27.65%   253-400
R/assaySpec.R            53      39  26.42%   104-146
R/barplot.R             173     140  19.08%   38-62, 120-260
R/boxplot.R             176     148  15.91%   39-63, 116-261
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       90      57  36.67%   97, 215-283
R/forestplot.R          200     175  12.50%   57-88, 143-309
R/geneSpec.R            256     153  40.23%   154-169, 296-480
R/km.R                  192     161  16.15%   60-89, 148-303
R/pca.R                 357     276  22.69%   33-53, 158-463
R/quality.R             302     232  23.18%   18-107, 200-432
R/sampleVarSpec.R       236     104  55.93%   299, 318-327, 333-340, 342, 350-362, 364-365, 367, 370, 378-382, 384-399, 404-428, 431-435, 437, 444-454, 456-457, 465, 510-527
R/scatterplot.R         171     141  17.54%   38-62, 119-259
R/utils.R                16       0  100.00%
R/volcanoplot.R         196     167  14.80%   33-54, 107-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2607    1926  26.12%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 78bb4e7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

Unit Tests Summary

  1 files   15 suites   11s ⏱️
 56 tests  43 ✅ 13 💤 0 ❌
538 runs  525 ✅ 13 💤 0 ❌

Results for commit 78bb4e7.

@BFalquet BFalquet merged commit d71e115 into main Feb 21, 2024
21 checks passed
@BFalquet BFalquet deleted the 360-bug-unexpected-reinitialization@main branch February 21, 2024 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: unexpected reinitialization
2 participants