Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

339 migrate to teal data@main #342

Merged
merged 37 commits into from
Nov 20, 2023
Merged

339 migrate to teal data@main #342

merged 37 commits into from
Nov 20, 2023

Conversation

m7pr
Copy link
Contributor

@m7pr m7pr commented Nov 8, 2023 •
edited
Loading

@m7pr m7pr added the core label Nov 8, 2023
@m7pr m7pr mentioned this pull request Nov 8, 2023
Closed
@m7pr m7pr marked this pull request as ready for review November 8, 2023 12:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 8, 2023 •
edited
Loading

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           168     121  27.98%   248-393
R/assaySpec.R            53      39  26.42%   106-148
R/barplot.R             169     136  19.53%   38-62, 121-257
R/boxplot.R             172     144  16.28%   39-63, 117-258
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 212-279
R/forestplot.R          196     171  12.76%   57-88, 144-306
R/geneSpec.R            256     153  40.23%   154-169, 296-480
R/km.R                  188     157  16.49%   60-89, 150-301
R/pca.R                 355     272  23.38%   33-53, 161-462
R/quality.R             298     228  23.49%   18-107, 201-429
R/sampleVarSpec.R       236     104  55.93%   293, 312-321, 327-334, 336, 344-356, 358-359, 361, 364, 372-376, 378-393, 398-422, 425-429, 431, 438-448, 450-451, 459, 504-521
R/scatterplot.R         167     137  17.96%   38-62, 120-256
R/utils.R                16       0  100.00%
R/volcanoplot.R         193     163  15.54%   33-54, 109-278
R/zzz.R                   1       1  0.00%    2
TOTAL                  2575    1891  26.56%

Diff against main

Filename           Stmts    Miss  Cover
---------------  -------  ------  -------
R/barplot.R           -2      -2  +0.23%
R/boxplot.R           -2      -2  +0.19%
R/forestplot.R        -3      -3  +0.19%
R/km.R                -3      -3  +0.26%
R/pca.R               -2      -2  +0.13%
R/quality.R           -2      -2  +0.16%
R/scatterplot.R       -2      -2  +0.21%
R/volcanoplot.R       -2      -2  +0.16%
TOTAL                -18     -18  +0.18%

Results for commit: 8e28189

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

m7pr
m7pr commented Nov 8, 2023
View reviewed changes
DESCRIPTION Outdated
rtables (>= 0.5.1),
S4Vectors,
shinyRadioMatrix (>= 0.2.1),
shinyWidgets,
stats,
stringr,
SummarizedExperiment,
teal.data (>= 0.3.0),
teal.data (>= 0.3.0.9008),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be bumped to 0.4.0

m7pr
m7pr commented Nov 8, 2023
View reviewed changes
NAMESPACE Outdated Show resolved Hide resolved
m7pr
m7pr commented Nov 8, 2023
View reviewed changes
R/package.R Outdated Show resolved Hide resolved
m7pr
m7pr commented Nov 8, 2023
View reviewed changes
R/adtteSpec.R Outdated Show resolved Hide resolved
m7pr
m7pr commented Nov 8, 2023
View reviewed changes
R/forestplot.R Outdated Show resolved Hide resolved
m7pr
m7pr commented Nov 8, 2023
View reviewed changes
R/forestplot.R Outdated Show resolved Hide resolved
m7pr
m7pr commented Nov 8, 2023
View reviewed changes
R/km.R Outdated Show resolved Hide resolved
danielinteractive
danielinteractive approved these changes Nov 8, 2023
View reviewed changes
Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @m7pr , looks good to me

design/design_km.Rmd Outdated Show resolved Hide resolved
@vedhav vedhav mentioned this pull request Nov 9, 2023
Merged
34 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 14, 2023 •
edited
Loading

Unit Tests Summary

    1 files    15 suites   12s ⏱️
  56 tests   43 ✔️ 13 💤 0 ❌
538 runs  525 ✔️ 13 💤 0 ❌

Results for commit 8e28189.

♻️ This comment has been updated with latest results.

@m7pr m7pr mentioned this pull request Nov 16, 2023
Closed
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 17, 2023 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
adtteSpec 💔 $10.27$ $+1.39$ $+444$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
adtteSpec 💔 $0.35$ $+1.09$ h_km_mae_to_adtte_function_also_works_when_some_ID_variables_are_factors

Results for commit 07c4217

♻️ This comment has been updated with latest results.

gogonzo
gogonzo reviewed Nov 20, 2023
View reviewed changes
R/forestplot.R Outdated Show resolved Hide resolved
@gogonzo
Copy link
Contributor

gogonzo commented Nov 20, 2023

@m7pr please change the branch to 78_simplify_joinkeys@main

@vedhav vedhav enabled auto-merge (squash) November 20, 2023 11:25
@vedhav vedhav merged commit fd679d9 into main Nov 20, 2023
23 checks passed
@vedhav vedhav deleted the 339_migrate_to_teal_data@main branch November 20, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vedhav vedhav vedhav left review comments

@gogonzo gogonzo gogonzo left review comments

@danielinteractive danielinteractive danielinteractive approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace TealData with teal_data in the docs
4 participants
@m7pr @gogonzo @danielinteractive @vedhav