Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable dropdown on encondings if no option is available #332

Merged
merged 7 commits into from
Sep 12, 2023

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes #324

Possible simplification:

Use of shinyjs::enable()/shinyjs::disable() would remove the custom message handler with the caveat of adding a dependency to the package.

Changes description

  • Use of selectizeInput instead of selectizeInput
  • Adds placeholder to adtteSpecInput, assaySpecInput & geneSpec
    • Harcoded string: - Nothing selected -
  • Uses JS to disable / enable the dropdown
    • note: the message handler can be run multiple times, but it will only re-define the function per Shiny documentation

@averissimo averissimo added the enhancement New feature or request label Sep 11, 2023
@averissimo averissimo changed the title 324 disable empty select encoding@main Disable dropdown on encondings if no option available Sep 11, 2023
@averissimo averissimo changed the title Disable dropdown on encondings if no option available Disable dropdown on encondings if no option is available Sep 11, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

Unit Tests Summary

  1 files  15 suites   11s ⏱️
56 tests 43 ✔️ 13 💤 0
89 runs  76 ✔️ 13 💤 0

Results for commit fd36f1d.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@danielinteractive danielinteractive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @averissimo , can you please also update the tests accordingly?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 11, 2023

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           168     121  27.98%   252-397
R/assaySpec.R            53      39  26.42%   109-151
R/barplot.R             169     136  19.53%   40-64, 123-259
R/boxplot.R             172     144  16.28%   41-65, 119-260
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       89      56  37.08%   97, 215-282
R/forestplot.R          197     172  12.69%   60-91, 147-312
R/geneSpec.R            256     153  40.23%   154-169, 298-482
R/km.R                  189     158  16.40%   63-92, 153-307
R/pca.R                 355     272  23.38%   35-55, 163-464
R/quality.R             298     228  23.49%   18-109, 203-431
R/sampleVarSpec.R       236     104  55.93%   295, 314-323, 329-336, 338, 346-358, 360-361, 363, 366, 374-378, 380-395, 400-424, 427-431, 433, 440-450, 452-453, 461, 506-523
R/scatterplot.R         167     137  17.96%   40-64, 122-258
R/utils.R                16       0  100.00%
R/volcanoplot.R         193     163  15.54%   35-56, 111-280
R/zzz.R                   1       1  0.00%    2
TOTAL                  2577    1893  26.54%

Diff against main

Filename         Stmts    Miss  Cover
-------------  -------  ------  -------
R/adtteSpec.R      +12      +8  +0.41%
R/assaySpec.R       +9      +3  +8.23%
R/geneSpec.R        +1       0  +0.23%
R/utils.R            0      -5  +31.25%
TOTAL              +22      +6  +0.40%

Results for commit: b98b9f9

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@averissimo
Copy link
Contributor Author

averissimo commented Sep 12, 2023

@danielinteractive Oops, sorry I missed those before pushing

I've adapted the tests to the new HTML tag.

@averissimo averissimo merged commit 2dc132a into main Sep 12, 2023
23 checks passed
@averissimo averissimo deleted the 324_disable-empty-select-encoding@main branch September 12, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Disable select input when there are no choices
2 participants