Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #374 remove all references to scda #380

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Conversation

zdz2101
Copy link
Contributor

@zdz2101 zdz2101 commented Apr 30, 2024

Swaps out the call to library(scda) for library(random.cdisc.data) and brings for the ADTTE object as appropriate from rcd as well

@zdz2101 zdz2101 linked an issue Apr 30, 2024 that may be closed by this pull request
@zdz2101 zdz2101 requested review from edelarua and shajoezhu April 30, 2024 21:53
Copy link
Contributor

github-actions bot commented Apr 30, 2024

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@zdz2101
Copy link
Contributor Author

zdz2101 commented Apr 30, 2024

I have read the CLA Document and I hereby sign the CLA

Copy link
Contributor

badge

Code Coverage Summary

Filename              Stmts    Miss  Cover    Missing
------------------  -------  ------  -------  -------------------------------------------------------------------------------------------------------------------------------
R/adtteSpec.R           170     123  27.65%   253-400
R/assaySpec.R            53      39  26.42%   104-146
R/barplot.R             187     151  19.25%   39-66, 129-279
R/boxplot.R             189     158  16.40%   40-67, 125-278
R/checkmate.R            18       9  50.00%   110-118
R/experimentSpec.R       90      57  36.67%   97, 215-283
R/forestplot.R          213     185  13.15%   58-92, 152-326
R/geneSpec.R            256     153  40.23%   154-169, 296-480
R/km.R                  207     173  16.43%   61-92, 156-325
R/pca.R                 366     283  22.68%   34-56, 165-476
R/quality.R             319     246  22.88%   18-110, 208-453
R/sampleVarSpec.R       236     104  55.93%   299, 318-327, 333-340, 342, 350-362, 364-365, 367, 370, 378-382, 384-399, 404-428, 431-435, 437, 444-454, 456-457, 465, 510-527
R/scatterplot.R         180     147  18.33%   39-65, 127-272
R/utils.R                16       0  100.00%
R/volcanoplot.R         203     173  14.78%   34-57, 113-292
R/zzz.R                   2       2  0.00%    2-3
TOTAL                  2705    2003  25.95%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a3583c3

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

@edelarua edelarua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

Copy link
Contributor

github-actions bot commented Apr 30, 2024

Unit Tests Summary

  1 files   15 suites   11s ⏱️
 56 tests  43 ✅ 13 💤 0 ❌
538 runs  525 ✅ 13 💤 0 ❌

Results for commit a3583c3.

♻️ This comment has been updated with latest results.

@zdz2101 zdz2101 merged commit 5e6a311 into main Apr 30, 2024
24 of 25 checks passed
@zdz2101 zdz2101 deleted the 374_replace_scda_w_rcd branch April 30, 2024 22:06
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replacing scda and scda.2022 useage by rcd sme
2 participants