Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replacing scda and scda.2022 useage by rcd sme #374

Closed
shajoezhu opened this issue Mar 27, 2024 · 2 comments · Fixed by #380
Closed

replacing scda and scda.2022 useage by rcd sme #374

shajoezhu opened this issue Mar 27, 2024 · 2 comments · Fixed by #380
Assignees
@zdz2101
Labels
sme

Comments

@shajoezhu
Copy link

No description provided.

@shajoezhu shajoezhu added the sme label Mar 27, 2024
@zdz2101 zdz2101 self-assigned this Apr 30, 2024
@zdz2101
Copy link
Contributor

zdz2101 commented Apr 30, 2024

@shajoezhu @edelarua looks like PR handled the the decoupling of it, however data-raw/data.R still mentions library(scda) but it is also technically already in the .Rbuildignore ? Is it supposed to be swapped appropriate with RCD call and assure everything still runs correctly?

@edelarua
Copy link
Contributor

@zdz2101 yes, I would replace it there as well so there's no mention of it anywhere in the package.

@edelarua edelarua mentioned this issue Apr 30, 2024
Closed
2 tasks
@zdz2101 zdz2101 linked a pull request Apr 30, 2024 that will close this issue
Closes #374 remove all references to scda #380
Merged
zdz2101 added a commit that referenced this issue Apr 30, 2024
@zdz2101
Closes #374 remove all references to scda (#380)
5e6a311 
Swaps out the call to `library(scda)` for `library(random.cdisc.data)`
and brings for the `ADTTE` object as appropriate from rcd as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zdz2101 zdz2101

Labels
sme
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Closes #374 remove all references to scda insightsengineering/teal.modules.hermes
3 participants
@shajoezhu @zdz2101 @edelarua