Skip to content

Commit

Permalink
update snapshot, add wait_for_idle (#369)
Browse files Browse the repository at this point in the history
- update snapshots
- add waiting for idle

thank you for the review

Co-authored-by: benoit <[email protected]>
  • Loading branch information
BFalquet and benoit authored Mar 13, 2024
1 parent 1b9e230 commit e590ea5
Show file tree
Hide file tree
Showing 14 changed files with 3 additions and 1 deletion.
Binary file modified tests/testthat/_snaps/windows-4.3/boxplot/boxplot-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/forest/forest_tte-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/pca/pca-004.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/pca/pca-007.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/pca/pca-008.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/pca/pca-009.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/pca/pca-010.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/quality/quality-003.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-001.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-002.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion tests/testthat/test-pca.R
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ test_that("pca module works as expected in the test app", {
app$set_inputs(!!ns("show_matrix") := TRUE)

app$set_inputs(!!ns2("add-MAE-subjects-var_to_add") := "SEX")
app$wait_for_idle()
app$wait_for_idle(timeout = 40000)
app$set_inputs(!!ns2("active-MAE-subjects-MAE_SEX-inputs-selection") := "M")

# Ensure xvar and yvar get resetted to pc1 and pc2.
Expand Down
2 changes: 2 additions & 0 deletions tests/testthat/test-quality.R
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ test_that("quality module works as expected in the test app", {
app$wait_for_idle(timeout = 20000)
ns <- module_ns_shiny2(app)


# Check initial state of encodings.
res <- app$get_value(input = ns("experiment-name"))
expect_identical(res, "hd1")
Expand Down Expand Up @@ -67,6 +68,7 @@ test_that("quality module works as expected in the test app", {
# Change to another plot type so that we can choose another assay.
app$set_inputs(!!ns("plot_type") := "Top Genes Plot")
app$set_inputs(!!ns("assay-name") := "cpm")
app$wait_for_idle(timeout = 30000)
app$expect_select_screenshot(ns("plot-plot_out_main"))
app$stop()
})
Expand Down

0 comments on commit e590ea5

Please sign in to comment.