update tests

insightsengineering · Feb 20, 2024 · 5f2f286 · 5f2f286
1 parent 04e8bed
commit 5f2f286
Show file tree

Hide file tree

Showing 21 changed files with 11 additions and 4 deletions.
diff --git a/tests/testthat/_snaps/windows-4.3/barplot/barplot-001.png b/tests/testthat/_snaps/windows-4.3/barplot/barplot-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/boxplot/boxplot-001.png b/tests/testthat/_snaps/windows-4.3/boxplot/boxplot-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/forest/forest_tte-001.png b/tests/testthat/_snaps/windows-4.3/forest/forest_tte-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/km/km-001.png b/tests/testthat/_snaps/windows-4.3/km/km-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-001.png b/tests/testthat/_snaps/windows-4.3/pca/pca-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-002.png b/tests/testthat/_snaps/windows-4.3/pca/pca-002.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-003.png b/tests/testthat/_snaps/windows-4.3/pca/pca-003.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-004.png b/tests/testthat/_snaps/windows-4.3/pca/pca-004.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-005.png b/tests/testthat/_snaps/windows-4.3/pca/pca-005.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-007.png b/tests/testthat/_snaps/windows-4.3/pca/pca-007.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-008.png b/tests/testthat/_snaps/windows-4.3/pca/pca-008.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-009.png b/tests/testthat/_snaps/windows-4.3/pca/pca-009.png
diff --git a/tests/testthat/_snaps/windows-4.3/pca/pca-010.png b/tests/testthat/_snaps/windows-4.3/pca/pca-010.png
diff --git a/tests/testthat/_snaps/windows-4.3/quality/quality-001.png b/tests/testthat/_snaps/windows-4.3/quality/quality-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/quality/quality-002.png b/tests/testthat/_snaps/windows-4.3/quality/quality-002.png
diff --git a/tests/testthat/_snaps/windows-4.3/quality/quality-003.png b/tests/testthat/_snaps/windows-4.3/quality/quality-003.png
diff --git a/tests/testthat/_snaps/windows-4.3/scatterplot/scatterplot-001.png b/tests/testthat/_snaps/windows-4.3/scatterplot/scatterplot-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-001.png b/tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-001.png
diff --git a/tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-002.png b/tests/testthat/_snaps/windows-4.3/volcanoplot/volcanoplot-002.png
diff --git a/tests/testthat/test-barplot.R b/tests/testthat/test-barplot.R
@@ -88,6 +88,7 @@ test_that("barplot module works as expected in the test app", {
     !!ns("facet-sample_var") := "AGE18"
   )
 
+  app$wait_for_idle()
   app$expect_select_screenshot(ns("plot-plot_out_main"))
 })
 

diff --git a/tests/testthat/test-experimentSpec.R b/tests/testthat/test-experimentSpec.R
@@ -156,6 +156,10 @@ test_that("experimentSpec module works as expected in the test app", {
   app$set_inputs(!!ns2("active-MAE-subjects-MAE_SEX-inputs-selection") := character())
   app$wait_for_idle()
 
+  # Experiment selection is not affected by filtering
+  res <- app$get_value(input = ns("my_experiment-name"))
+  expect_identical(res, "hd2")
+
   res <- app$get_value(output = ns("summary"))
   expect_match(res$message, "No genes or samples included in this experiment, please adjust filters")
   app$click(ns2("active-MAE-remove_filters"))
@@ -174,8 +178,9 @@ test_that("experimentSpec module works as expected in the test app", {
   )
   app$wait_for_idle()
 
-  app$set_inputs(!!ns("my_experiment-name") := "hd2")
-  app$wait_for_idle()
+  # Experiment selection is not affected by filtering
+  res <- app$get_value(input = ns("my_experiment-name"))
+  expect_identical(res, "hd2")
 
   res <- app$get_value(output = ns("summary"))
   expect_match(res$message, "No genes or samples included in this experiment, please adjust filters")
@@ -184,8 +189,9 @@ test_that("experimentSpec module works as expected in the test app", {
   app$click(ns2("active-MAE-remove_filters"))
   app$wait_for_idle()
 
-  app$set_inputs(!!ns("my_experiment-name") := "hd2")
-  app$wait_for_idle()
+  # Experiment selection is not affected by removing filters
+  res <- app$get_value(input = ns("my_experiment-name"))
+  expect_identical(res, "hd2")
 
   res <- app$get_value(output = ns("summary"))
   expect_match(res, "HermesData object with 9 samples of 2500 genes")
-Original file line number
+Diff line change
@@ Expand Up @@
         !!ns("facet-sample_var") := "AGE18"
       )
+      app$wait_for_idle()
       app$expect_select_screenshot(ns("plot-plot_out_main"))
     })
@@ Expand Down @@