fix: remove rlang call and add changes to NEWS

insightsengineering · Sep 11, 2023 · 095e334 · 095e334
1 parent 8ed01b1
commit 095e334
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,9 @@
 # teal.modules.hermes 0.1.5.9002
 
+### Miscellaneous
+* Added placeholders for `assaySpec`, `adtteSpec` and `geneSpec` inputs when no option is selected.
+* Disabled the dropdown input for `assaySpec` and `adtteSpec` when there are no options available.
+
 # teal.modules.hermes 0.1.5
 
 ### Bug Fixes

diff --git a/R/adtteSpec.R b/R/adtteSpec.R
@@ -328,7 +328,7 @@ adtteSpecServer <- function(id, # nolint
       )
       session$sendCustomMessage(
         "toggle_dropdown",
-        list(input_id = session$ns("paramcd"), disabled = rlang::is_empty(paramcd_choices))
+        list(input_id = session$ns("paramcd"), disabled = (length(paramcd_choices) == 0))
       )
     })
 

diff --git a/R/assaySpec.R b/R/assaySpec.R
@@ -136,7 +136,7 @@ assaySpecServer <- function(id, # nolint
       updateSelectizeInput(session, "name", choices = choices)
       session$sendCustomMessage(
         "toggle_dropdown",
-        list(input_id = session$ns("name"), disabled = rlang::is_empty(choices))
+        list(input_id = session$ns("name"), disabled = (length(choices) == 0))
       )
     })