introduce decorators for tm_t_crosstable

[m7pr]

Part of insightsengineering/teal#1370

Working Example

devtools::load_all("../teal")
devtools::load_all(".")


split_by_decorator <- teal_transform_module(
  label = "Footnote",
  ui = function(id) shiny::textInput(
    shiny::NS(id, "text"), "Insert row", "Hello World!" 
  ),
  server = function(id, data) {
    moduleServer(id, function(input, output, session) {
      logger::log_info("🟢 Text called to action!", namespace = "teal.modules.general")
      reactive(
        within(
          data(),
          {
              table <- table %>% insert_rrow(rrow(text))
          },
          text = input$text
        )
      )
    })
  }
)

# CDISC data example
data <- teal_data()
data <- within(data, {
  ADSL <- rADSL
})
join_keys(data) <- default_cdisc_join_keys[names(data)]

app <- init(
  data = data,
  modules = modules(
    tm_t_crosstable(
      label = "Cross Table",
      x = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          label = "Select variable:",
          choices = variable_choices(data[["ADSL"]], subset = function(data) {
            idx <- !vapply(data, inherits, logical(1), c("Date", "POSIXct", "POSIXlt"))
            return(names(data)[idx])
          }),
          selected = "COUNTRY",
          multiple = TRUE,
          ordered = TRUE,
          fixed = FALSE
        )
      ),
      y = data_extract_spec(
        dataname = "ADSL",
        select = select_spec(
          label = "Select variable:",
          choices = variable_choices(data[["ADSL"]], subset = function(data) {
            idx <- vapply(data, is.factor, logical(1))
            return(names(data)[idx])
          }),
          selected = "SEX",
          multiple = FALSE,
          fixed = FALSE
        )
      ),
      decorators = list(split_by_decorator)
    )
  )
)
if (interactive()) {
  shinyApp(app$ui, app$server)
}

[github-actions]

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    106-1066
R/tm_a_regression.R             808     808  0.00%    160-1071
R/tm_data_table.R               185     185  0.00%    100-339
R/tm_file_viewer.R              173     173  0.00%    47-255
R/tm_front_page.R               133     122  8.27%    73-231
R/tm_g_association.R            330     330  0.00%    134-536
R/tm_g_bivariate.R              672     410  38.99%   301-767, 808, 919, 936, 954, 965-987
R/tm_g_distribution.R          1048    1048  0.00%    125-1311
R/tm_g_response.R               351     351  0.00%    151-575
R/tm_g_scatterplot.R            722     722  0.00%    233-1056
R/tm_g_scatterplotmatrix.R      278     259  6.83%    172-479, 540, 554
R/tm_missing_data.R            1070    1070  0.00%    91-1317
R/tm_outliers.R                 985     985  0.00%    129-1258
R/tm_t_crosstable.R             255     255  0.00%    147-451
R/tm_variable_browser.R         830     825  0.60%    89-1081, 1119-1303
R/utils.R                        99      96  3.03%    84-269
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8768    8468  3.42%

Diff against main

Filename               Stmts    Miss  Cover
-------------------  -------  ------  --------
R/tm_a_regression.R      +35     +35  +100.00%
R/tm_t_crosstable.R       +4      +4  +100.00%
TOTAL                    +39     +39  -0.02%

Results for commit: 51f6882

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_pca	💔	$120.63$	$+1.47$	$0$	$0$	$0$	$0$
shinytest2-tm_a_regression	💔	$54.97$	$+11.88$	$0$	$0$	$0$	$0$
shinytest2-tm_g_bivariate	💔	$74.92$	$+1.38$	$0$	$0$	$0$	$0$
shinytest2-tm_g_scatterplot	💔	$74.74$	$+1.20$	$0$	$0$	$0$	$0$
shinytest2-tm_outliers	💔	$107.55$	$+1.58$	$0$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_regression	💔	$13.46$	$+5.28$	e2e_tm_a_regression_Plot_type_has_7_specific_choices_changing_choices_does_not_throw_errors.
shinytest2-tm_a_regression	💔	$6.66$	$+2.24$	e2e_tm_a_regression_Plot_type_is_set_properly.
shinytest2-tm_a_regression	💔	$10.10$	$+1.28$	e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition.

Results for commit 3579bc1

♻️ This comment has been updated with latest results.

[m7pr]

Thanks @averissimo for the review. I accepted changes and run the example app again. Now everything is perfect. Asked for another round of the reviews

[averissimo]

Let's goooooo!!