Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes data reactivity in tm_missing_data #773

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes #772

Changes description

  • Convert data -> data()
  • Use datanames() instead of names()

Copy link
Contributor

github-actions bot commented Aug 14, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    108-1068
R/tm_a_regression.R             773     773  0.00%    153-1031
R/tm_data_table.R               185     185  0.00%    93-332
R/tm_file_viewer.R              173     173  0.00%    44-252
R/tm_front_page.R               133     122  8.27%    70-228
R/tm_g_association.R            330     330  0.00%    135-537
R/tm_g_bivariate.R              672     410  38.99%   303-769, 810, 921, 938, 956, 967-989
R/tm_g_distribution.R          1050    1050  0.00%    122-1311
R/tm_g_response.R               351     351  0.00%    154-578
R/tm_g_scatterplot.R            722     722  0.00%    230-1053
R/tm_g_scatterplotmatrix.R      278     259  6.83%    165-472, 533, 547
R/tm_missing_data.R            1069    1069  0.00%    92-1317
R/tm_outliers.R                 985     985  0.00%    134-1263
R/tm_t_crosstable.R             251     251  0.00%    141-440
R/tm_variable_browser.R         830     825  0.60%    79-1071, 1109-1293
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           2       2  0.00%    2-3
TOTAL                          8730    8430  3.44%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 602ccb7

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Unit Tests Summary

  1 files   22 suites   13m 16s ⏱️
147 tests 147 ✅ 0 💤 0 ❌
478 runs  478 ✅ 0 💤 0 ❌

Results for commit 602ccb7.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Aug 14, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_regression 💚 $55.78$ $-2.64$ $0$ $0$ $0$ $0$
shinytest2-tm_g_bivariate 💚 $77.11$ $-1.50$ $0$ $0$ $0$ $0$
shinytest2-tm_g_distribution 💚 $58.90$ $-1.10$ $0$ $0$ $0$ $0$
shinytest2-tm_g_scatterplot 💚 $75.76$ $-2.15$ $0$ $0$ $0$ $0$
shinytest2-tm_misssing_data 💚 $50.08$ $-2.92$ $0$ $0$ $0$ $0$
shinytest2-tm_outliers 💚 $104.78$ $-2.71$ $0$ $0$ $0$ $0$
shinytest2-tm_t_crosstable 💚 $34.77$ $-2.81$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_regression 💚 $12.44$ $-2.01$ e2e_tm_a_regression_Unchecking_display_outlier_hides_outlier_label_and_definition.
shinytest2-tm_g_bivariate 💚 $26.40$ $-1.73$ e2e_tm_g_bivariate_Setting_encoding_inputs_produces_outputs_without_validation_errors.
shinytest2-tm_misssing_data 💚 $14.92$ $-2.55$ e2e_tm_missing_data_Default_settings_and_visibility_of_the_summary_graph
shinytest2-tm_outliers 💚 $26.70$ $-2.18$ e2e_tm_outliers_Outlier_definition_text_and_range_are_displayed_properly_depending_on_method.
shinytest2-tm_t_crosstable 💚 $12.82$ $-2.22$ e2e_tm_t_crosstable_Change_plot_settings

Results for commit 45043b3

♻️ This comment has been updated with latest results.

R/tm_missing_data.R Outdated Show resolved Hide resolved
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@averissimo averissimo enabled auto-merge (squash) August 14, 2024 14:29
@averissimo averissimo merged commit a503250 into main Aug 14, 2024
29 checks passed
@averissimo averissimo deleted the 772-data_reactive@main branch August 14, 2024 14:32
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: tm_missing_data is not calling data correctly when determining parent dataname
2 participants