shinyApp chunk in vignettes only runs if is in interactive mode

[averissimo]

Pull Request

• Fixes [Bug]: Vignettes have a shinyApp call that makes rcmdcheck() run forever #740
• Fixes GRAN fail build #729

Changes description

• add eval=base::interactive() to chunk options in vignettes

How to test

• Run rmcdcheck::rmcdcheck()
• Run scheduled.yaml Github action and all strategies complete successfully
  • Currently they're taking 6h+ hours and failing
  • Badge for this branch:

[github-actions]

Unit Tests Summary

  1 files   22 suites   10m 42s ⏱️
147 tests 147 ✅ 0 💤 0 ❌
478 runs  478 ✅ 0 💤 0 ❌

Results for commit 67392cd.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_variable_browser	💔	$47.98$	$+1.78$	$0$	$0$	$0$	$0$

Results for commit d8739f8

♻️ This comment has been updated with latest results.

[pawelru]

This looks good. I two comments:

• can you please check whether runtime: shiny is required. I actually have no idea what it does
• (assuming we already depend on rlang) have you considered rlang::is_interactive(). This is the function I have discovered quite recently and I don't know whether this is really better than the one from base.

[averissimo]

runtime: shiny

• can you please check whether runtime: shiny is required. I actually have no idea what it does

BLUF: It's not necessary and it does nothing in this case. I'm removing it.

Some context

It does not allow a ShinyApp though. Hence why it does nothing here.

When this runtime is set to shiny it allows for shiny elements on the rendered markdown (but not on pkgdown sites)

(from docs) The runtime target for rendering. The static option produces output intended for static files; shiny produces output suitable for use in a Shiny document (see run). The default, auto, allows the runtime target specified in the YAML metadata to take precedence, and renders for a static runtime target otherwise.

rlang::is_interactive()

• (assuming we already depend on rlang) have you considered rlang::is_interactive(). This is the function I have discovered quite recently and I don't know whether this is really better than the one from base.

No practical benefits here, but rlang::is_interactive() is technically better as it will detect the right context . Unlike, base::interactive that only detects if there is an interactive session.

When can it be helpful?

1. Forcing the result to be either value (via global option)
2. Manual running knitr or testthat in a console
   • rlang::is_interactive() as FALSE, where base version is TRUE

[averissimo]

The {verdepcheck} GitHub workflow ran successfully

This PR should also fix the GRAN and r-universe build fails.

[pawelru]

Thank you!