Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip vbump] upversion to 0.3.0 #704

Merged
merged 2 commits into from
Mar 5, 2024
Merged

Conversation

donyunardi
Copy link
Contributor

Related with #623

@donyunardi donyunardi added the core label Mar 1, 2024
Copy link
Contributor

github-actions bot commented Mar 1, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    108-1068
R/tm_a_regression.R             776     776  0.00%    153-1033
R/tm_data_table.R               179     179  0.00%    93-325
R/tm_file_viewer.R              170     170  0.00%    44-248
R/tm_front_page.R               129     118  8.53%    70-222
R/tm_g_association.R            334     334  0.00%    135-541
R/tm_g_bivariate.R              671     411  38.75%   306-771, 812, 923, 940, 958, 969-991
R/tm_g_distribution.R          1042    1042  0.00%    122-1299
R/tm_g_response.R               350     350  0.00%    154-577
R/tm_g_scatterplot.R            726     726  0.00%    230-1057
R/tm_g_scatterplotmatrix.R      282     263  6.74%    165-476, 537, 551
R/tm_missing_data.R            1058    1058  0.00%    92-1304
R/tm_outliers.R                 988     988  0.00%    134-1265
R/tm_t_crosstable.R             255     255  0.00%    141-444
R/tm_variable_browser.R         825     820  0.61%    79-1064, 1102-1286
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           1       1  0.00%    2
TOTAL                          8712    8414  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: a1bee3c

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Mar 1, 2024

Unit Tests Summary

 1 files   6 suites   0s ⏱️
29 tests 29 ✅ 0 💤 0 ❌
67 runs  67 ✅ 0 💤 0 ❌

Results for commit a1bee3c.

♻️ This comment has been updated with latest results.

@donyunardi
Copy link
Contributor Author

We got feedback:

Thanks, we see:

Size of tarball: 9729972 bytes

Please reduce to less than 5 MB.

I'll see if I can reduce the images for vignettes

@donyunardi
Copy link
Contributor Author

donyunardi commented Mar 1, 2024

Resize the vignette's png size and got < 5MB for the tmg tarball.
Rebuild the site locally and the image is still legible to view.

@donyunardi
Copy link
Contributor Author

Resubmit to CRAN.
Awaiting feedback.

@gogonzo
Copy link
Contributor

gogonzo commented Mar 4, 2024

CRAN feedback

Please reduce to less than 5 MB.

PR here #705

@donyunardi
Copy link
Contributor Author

I have already resized the package by reducing the vignette's PNG file size and resubmitted it to CRAN.
We're still waiting for CRAN to get back at us.

@donyunardi
Copy link
Contributor Author

Package is now in CRAN.

@donyunardi donyunardi merged commit c57c2b8 into main Mar 5, 2024
39 checks passed
@donyunardi donyunardi deleted the release-candidate-v0.3.0 branch March 5, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants