Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the internal function var_labels in favour of teal.data::col_labels #690

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Remove the internal function var_labels in favour of teal.data::col_labels #690

merged 1 commit into from
Feb 27, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Feb 27, 2024

Closes #689

@vedhav vedhav added the core label Feb 27, 2024
@vedhav vedhav requested a review from gogonzo February 27, 2024 10:34
gogonzo
gogonzo approved these changes Feb 27, 2024
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I appreciate every commit with negative line balance

@github-actions GitHub Actions
Copy link
Contributor

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  -----------------------------------------------
R/tm_a_pca.R                    825     825  0.00%    111-1060
R/tm_a_regression.R             716     716  0.00%    139-938
R/tm_data_table.R               177     177  0.00%    91-317
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    130-521
R/tm_g_bivariate.R              655     495  24.43%   192-773, 821, 827, 831, 942, 959, 977, 997-1019
R/tm_g_distribution.R          1028    1028  0.00%    121-1271
R/tm_g_response.R               351     351  0.00%    139-554
R/tm_g_scatterplot.R            719     719  0.00%    236-1046
R/tm_g_scatterplotmatrix.R      280     261  6.79%    163-460, 514, 528
R/tm_missing_data.R            1054    1054  0.00%    87-1280
R/tm_outliers.R                 976     976  0.00%    132-1238
R/tm_t_crosstable.R             254     254  0.00%    134-426
R/tm_variable_browser.R         820     815  0.61%    86-1314
R/utils.R                       100     100  0.00%    72-300
R/zzz.R                           1       1  0.00%    2
TOTAL                          8589    8394  2.27%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
R/utils.R       -22     -22  +100.00%
TOTAL           -22     -22  +0.01%

Results for commit: 5e345fe

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

@github-actions GitHub Actions
Copy link
Contributor

Unit Tests Summary

 1 files   5 suites   0s ⏱️
16 tests 16 ✅ 0 💤 0 ❌
49 runs  49 ✅ 0 💤 0 ❌

Results for commit 5e345fe.

@vedhav vedhav merged commit 0331c61 into main Feb 27, 2024
24 checks passed
@vedhav vedhav deleted the 689-remove-var_labels@main branch February 27, 2024 10:49
@m7pr
Copy link
Contributor

m7pr commented Feb 27, 2024

I appreciate every commit with negative line balance

Should this be our motto ;) ?

@chlebowa
Copy link
Contributor

What happened to this? #673

@m7pr
Copy link
Contributor

m7pr commented Feb 27, 2024

@vedhav you did it to main. This change was already on pre-release@main lol

@vedhav
Copy link
Contributor Author

vedhav commented Feb 27, 2024

🤦🏽 Sorry, I did not know about this. I should have checked the pre-release branch before I did this.

@chlebowa
Copy link
Contributor

Pay attention, please.

averissimo added a commit that referenced this pull request Feb 28, 2024
@averissimo
Merge remote-tracking branch 'origin/pre-release@main' into 686-asser…
f164561 
…tions_process@pre-release@main

* origin/pre-release@main:
  removed @nord tags and added return from shared_params
  missing comma
  641 non exported functions (#680)
  pre-release vignettes review (#681)
  [skip roxygen] [skip vbump] Roxygen Man Pages Auto Update
  Standardise function titles similar to what we have in tmc (#691)
  [skip actions] Bump version to 0.2.16.9026
  `tm_g_regression` labels are no longer allowed out of bounds (#675)
  [skip actions] Bump version to 0.2.16.9025
  Remove the internal function `var_labels` in favour of `teal.data::col_labels` (#690)
  [skip actions] Bump version to 0.2.16.9024
  Fix the silent error in `tm_a_pca` (#688)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gogonzo gogonzo gogonzo approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace var_labels with teal.data::col_labels
4 participants
@vedhav @m7pr @chlebowa @gogonzo