624 PACKAGE LEVEL pre-release activities #639

m7pr · 2024-02-19T11:32:56Z

Part of #624

Signed-off-by: Marcin <[email protected]>

github-actions · 2024-02-19T14:30:08Z

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    108-1068
R/tm_a_regression.R             776     776  0.00%    153-1033
R/tm_data_table.R               179     179  0.00%    93-325
R/tm_file_viewer.R              170     170  0.00%    44-248
R/tm_front_page.R               129     118  8.53%    70-222
R/tm_g_association.R            334     334  0.00%    135-541
R/tm_g_bivariate.R              671     411  38.75%   306-771, 812, 923, 940, 958, 969-991
R/tm_g_distribution.R          1042    1042  0.00%    122-1299
R/tm_g_response.R               350     350  0.00%    154-577
R/tm_g_scatterplot.R            726     726  0.00%    230-1057
R/tm_g_scatterplotmatrix.R      282     263  6.74%    165-476, 537, 551
R/tm_missing_data.R            1058    1058  0.00%    92-1304
R/tm_outliers.R                 988     988  0.00%    134-1265
R/tm_t_crosstable.R             255     255  0.00%    141-444
R/tm_variable_browser.R         825     820  0.61%    79-1064, 1102-1286
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           1       1  0.00%    2
TOTAL                          8712    8414  3.42%

Diff against main

Filename                      Stmts    Miss  Cover
--------------------------  -------  ------  --------
R/tm_a_pca.R                     +2      +2  +100.00%
R/tm_a_regression.R              -1      -1  +100.00%
R/tm_data_table.R                +2      +2  +100.00%
R/tm_file_viewer.R               -2      -2  +100.00%
R/tm_g_association.R             +2      +2  +100.00%
R/tm_g_bivariate.R               +6     -82  +12.88%
R/tm_g_distribution.R           +14     +14  +100.00%
R/tm_g_response.R                -1      -1  +100.00%
R/tm_g_scatterplot.R             +7      +7  +100.00%
R/tm_g_scatterplotmatrix.R       +2      +2  -0.05%
R/tm_missing_data.R              +4      +4  +100.00%
R/tm_outliers.R                 +11     +11  +100.00%
R/tm_t_crosstable.R              +1      +1  +100.00%
R/tm_variable_browser.R          +1      +1  -0.00%
R/utils.R                        -1      -4  +3.03%
TOTAL                           +47     -44  +1.03%

Results for commit: 92bdf31

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

github-actions · 2024-02-19T14:30:56Z

Unit Tests Summary

1 files 6 suites 0s ⏱️
29 tests 29 ✅ 0 💤 0 ❌
67 runs 67 ✅ 0 💤 0 ❌

Results for commit 92bdf31.

♻️ This comment has been updated with latest results.

.github/ISSUE_TEMPLATE/release.yml

R/tm_data_table.R

R/tm_file_viewer.R

vignettes/using-association-plot.Rmd

Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Marcin <[email protected]>

…ring/teal.modules.general into pre-release@main

Closes #642. Removed `substitute_q` and `extract_input`. Added `@keywords internal` to `is_num_var_short`.

Part of #624 From this #624 (comment) #### Changes description - Adds `@return` tag to `shared_params` to be reused across all documentation - Corrects linter errors

R/tm_t_crosstable.R

kartikeyakirar · 2024-03-01T08:26:02Z

Hey @m7pr, some some minor comments above. Apart from that, the PR looks good to go after #696.

# Pull Request - Fixes #686 - Part of #624 #### Changes descriptions - Adds missing assertions described on #686 - Adds a helper function called `assert_single_selection` - Avoids many repetitive calls across functions to check for multiple selections - Adds simple unit tests - Adds some comments to maintain a consistent structure --------- Signed-off-by: André Veríssimo <[email protected]> Co-authored-by: Dawid Kałędkowski <[email protected]>

…ring/teal.modules.general into pre-release@main

Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Marcin <[email protected]>

m7pr · 2024-03-01T09:56:52Z

Thanks @kartikeyakirar for cleaning up the finish line! Everything is merged and lasts checks are running.
We just need to get an acceptance on this PR. Any last (famous) words :D?

.github/workflows/check.yaml

github-actions · 2024-03-01T10:01:32Z

Unit Test Performance Difference

Test Suite	$Status$	Time on `main`	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
tm_g_bivariate	👶		$+0.25$	$+18$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	$±Time$	Test Case
tm_g_bivariate	👶	$+0.00$	tm_g_bivariate_creates_a_module_with_datanames_taken_from_data_extracts
tm_g_bivariate	👶	$+0.09$	tm_g_bivariate_creates_a_teal_module_object
tm_g_bivariate	👶	$+0.02$	tm_g_bivariate_creates_a_teal_module_object_with_default_options
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_creates_a_teal_module_object_with_multiple_data_extract_specs
tm_g_bivariate	👶	$+0.00$	tm_g_bivariate_determines_color_size_and_fill_when_color_setting_is_TRUE
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_fails_when_color_setting_is_FALSE_and_color_is_supplied
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_fails_when_color_setting_is_FALSE_and_fill_is_supplied
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_fails_when_color_setting_is_FALSE_and_size_is_supplied
tm_g_bivariate	👶	$+0.03$	tm_g_bivariate_fails_when_plot_height_is_not_valid
tm_g_bivariate	👶	$+0.03$	tm_g_bivariate_fails_when_plot_width_is_not_valid
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_fails_when_x_contains_a_spec_with_multiple_selection
tm_g_bivariate	👶	$+0.02$	tm_g_bivariate_fails_when_x_contains_multiple_spec_with_at_least_one_multiple_selection
tm_g_bivariate	👶	$+0.01$	tm_g_bivariate_fails_when_y_contains_multiple_spec_with_at_least_one_multiple_selection

Results for commit d7f056d

♻️ This comment has been updated with latest results.

DESCRIPTION

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

.github/workflows/release.yaml

Signed-off-by: Marcin <[email protected]>

vignettes/teal-modules-general.Rmd

DESCRIPTION

Signed-off-by: Marcin <[email protected]>

vignettes/teal-modules-general.Rmd

Signed-off-by: Marcin <[email protected]>

Corrected

averissimo

Looks good.

I went again through the initial bullet point list and it seems fine to merge!

.lintr

m7pr · 2024-03-01T11:04:39Z

Thanks @averissimo . I also did went again through the list, once you pointed some obvious mistakes!
Once #703 is merged, I'll merge this one.

#703) # Pull Request  - Part of #624 - Extends ANL rule to allow `ANL_OUTLIERS` and others variables that are prefixed with `ANL_` (in all caps)

averissimo · 2024-03-01T11:11:35Z

Fearless leader, we await the glorious merge 🐴 ⚔️

m7pr · 2024-03-01T12:12:31Z

veni, vidi, merge

initial DESCRIPTION curation

0072964

m7pr added the core label Feb 19, 2024

m7pr added 3 commits February 19, 2024 12:36

change DESCRIPTION's Title and Description fields

e5813a9

revisit README file

72164f7

change Teal to teal

549b0fa

m7pr mentioned this pull request Feb 19, 2024

Pre-release activities #624

Closed

26 tasks

m7pr and others added 5 commits February 19, 2024 13:10

check /main/ to /latest-tag/ in workflows files

b3845f0

add latest-tag/ to urls

7537fcc

Remove exception in .lintr: indentation_linter = NULL

7d0ff63

add LICENSE to .Rbuildignore

6767f42

Merge branch 'main' into pre-release@main

4d1d249

Signed-off-by: Marcin <[email protected]>

m7pr marked this pull request as ready for review February 19, 2024 14:24

m7pr requested review from averissimo, kartikeyakirar and a team February 19, 2024 14:24

averissimo reviewed Feb 19, 2024

View reviewed changes

.github/ISSUE_TEMPLATE/release.yml Outdated Show resolved Hide resolved

kartikeyakirar reviewed Feb 20, 2024

View reviewed changes

R/tm_data_table.R Outdated Show resolved Hide resolved

kartikeyakirar reviewed Feb 20, 2024

View reviewed changes

R/tm_file_viewer.R Outdated Show resolved Hide resolved

kartikeyakirar reviewed Feb 20, 2024

View reviewed changes

vignettes/using-association-plot.Rmd Outdated Show resolved Hide resolved

m7pr and others added 5 commits February 20, 2024 10:26

extend WORDLIST

ac43d53

Update vignettes/using-association-plot.Rmd

ee2d08b

Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Marcin <[email protected]>

revert template changes

f8d3583

Merge branch 'pre-release@main' of https://github.com/insightsenginee…

3bd9b71

…ring/teal.modules.general into pre-release@main

642 unused functions (#659)

c57bc17

Closes #642. Removed `substitute_q` and `extract_input`. Added `@keywords internal` to `is_num_var_short`.

m7pr requested review from averissimo and kartikeyakirar February 22, 2024 11:26

Adds common @return for modules and corrects linting (#670)

400d8cd

Part of #624 From this #624 (comment) #### Changes description - Adds `@return` tag to `shared_params` to be reused across all documentation - Corrects linter errors

pawelru reviewed Feb 22, 2024

View reviewed changes

R/tm_t_crosstable.R Show resolved Hide resolved

adding backtick on shiny keyword

cbae779

averissimo and others added 4 commits March 1, 2024 10:50

remove latest-tag from REPO url. this should onl stay in WEBSITE url

e209bf3

Merge branch 'pre-release@main' of https://github.com/insightsenginee…

3f9889f

…ring/teal.modules.general into pre-release@main

Update .pre-commit-config.yaml

92a25a5

Co-authored-by: kartikeya kirar <[email protected]> Signed-off-by: Marcin <[email protected]>

kartikeyakirar reviewed Mar 1, 2024

View reviewed changes

.github/workflows/check.yaml Outdated Show resolved Hide resolved

pawelru reviewed Mar 1, 2024

View reviewed changes

DESCRIPTION Outdated Show resolved Hide resolved

Update .github/workflows/check.yaml

2aa7e85

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

averissimo reviewed Mar 1, 2024

View reviewed changes

.github/workflows/release.yaml Outdated Show resolved Hide resolved

m7pr commented Mar 1, 2024

View reviewed changes

.github/workflows/release.yaml Outdated Show resolved Hide resolved

Update .github/workflows/release.yaml

8f95a49

Signed-off-by: Marcin <[email protected]>

m7pr mentioned this pull request Mar 1, 2024

643 potential removal of dependencies #663

Merged

averissimo previously requested changes Mar 1, 2024

View reviewed changes

vignettes/teal-modules-general.Rmd Outdated Show resolved Hide resolved

m7pr commented Mar 1, 2024

View reviewed changes

DESCRIPTION Outdated Show resolved Hide resolved

Update DESCRIPTION

f398140

Signed-off-by: Marcin <[email protected]>

m7pr commented Mar 1, 2024

View reviewed changes

vignettes/teal-modules-general.Rmd Outdated Show resolved Hide resolved

Update vignettes/teal-modules-general.Rmd

4dea7f3

Signed-off-by: Marcin <[email protected]>

m7pr requested a review from averissimo March 1, 2024 10:22

averissimo approved these changes Mar 1, 2024

View reviewed changes

averissimo reviewed Mar 1, 2024

View reviewed changes

.lintr Outdated Show resolved Hide resolved

Removes unnecessary # nolint after object_name_linter was changed (

92bdf31

#703) # Pull Request  - Part of #624 - Extends ANL rule to allow `ANL_OUTLIERS` and others variables that are prefixed with `ANL_` (in all caps)

m7pr merged commit 5c2fb78 into main Mar 1, 2024
26 checks passed

m7pr deleted the pre-release@main branch March 1, 2024 12:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

624 PACKAGE LEVEL pre-release activities #639

624 PACKAGE LEVEL pre-release activities #639

m7pr commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

kartikeyakirar commented Mar 1, 2024

m7pr commented Mar 1, 2024

github-actions bot commented Mar 1, 2024 •

edited

Loading

averissimo left a comment

m7pr commented Mar 1, 2024

averissimo commented Mar 1, 2024

m7pr commented Mar 1, 2024

624 PACKAGE LEVEL pre-release activities #639

624 PACKAGE LEVEL pre-release activities #639

Conversation

m7pr commented Feb 19, 2024 • edited Loading

github-actions bot commented Feb 19, 2024 • edited Loading

Code Coverage Summary

Diff against main

github-actions bot commented Feb 19, 2024 • edited Loading

Unit Tests Summary

kartikeyakirar commented Mar 1, 2024

m7pr commented Mar 1, 2024

github-actions bot commented Mar 1, 2024 • edited Loading

Unit Test Performance Difference

averissimo left a comment

Choose a reason for hiding this comment

m7pr commented Mar 1, 2024

averissimo commented Mar 1, 2024

m7pr commented Mar 1, 2024

m7pr commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Feb 19, 2024 •

edited

Loading

github-actions bot commented Mar 1, 2024 •

edited

Loading