Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

635 remove test theme #636

Merged
merged 10 commits into from
Feb 15, 2024
Merged

635 remove test theme #636

merged 10 commits into from
Feb 15, 2024

Conversation

chlebowa
Copy link
Contributor

@chlebowa chlebowa commented Feb 14, 2024

Closes #635

Added global variable, ggplot_themes, that lists all ggplot2 themes in a character vector.
ggplot_themes is used in all calls to selectInput that present a choice of themes.

Removed "test" from default arguments that specify initial theme.

Trimmed down formal argument descriptions.

Also, restyled the package documentation file to the currently recommended way ("_PACKAGE" replaceas @docType package).

Additionally, changed # nolint tags to state specific linters that are omitted and removed superfluous #nolint tags.

@chlebowa chlebowa added the core label Feb 14, 2024
Copy link
Contributor

github-actions bot commented Feb 14, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    826     826  0.00%    72-1022
R/tm_a_regression.R             716     716  0.00%    93-892
R/tm_data_table.R               177     177  0.00%    65-291
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    82-473
R/tm_g_bivariate.R              655     495  24.43%   128-709, 757, 763, 767, 878, 895, 913, 933-955
R/tm_g_distribution.R          1028    1028  0.00%    119-1269
R/tm_g_response.R               351     351  0.00%    88-503
R/tm_g_scatterplot.R            719     719  0.00%    160-970
R/tm_g_scatterplotmatrix.R      280     261  6.79%    80-377, 431, 445
R/tm_missing_data.R            1054    1054  0.00%    56-1249
R/tm_outliers.R                 976     976  0.00%    78-1183
R/tm_t_crosstable.R             254     254  0.00%    83-375
R/tm_variable_browser.R         820     815  0.61%    65-1293
R/utils.R                       122     122  0.00%    72-349
R/zzz.R                           1       1  0.00%    2
TOTAL                          8612    8417  2.26%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/tm_a_pca.R                  -3      -3  +100.00%
R/tm_variable_browser.R       -3      -3  +0.00%
TOTAL                         -6      -6  +0.00%

Results for commit: c99a900

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Feb 14, 2024

Unit Tests Summary

 1 files   5 suites   0s ⏱️
16 tests 16 ✅ 0 💤 0 ❌
49 runs  49 ✅ 0 💤 0 ❌

Results for commit c99a900.

♻️ This comment has been updated with latest results.

Aleksander Chlebowski added 2 commits February 15, 2024 08:25
R/zzz.R Show resolved Hide resolved
@m7pr
Copy link
Contributor

m7pr commented Feb 15, 2024

This is great, left just one comment, that I think we can over-come quickly

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chlebowa chlebowa enabled auto-merge (squash) February 15, 2024 15:12
@chlebowa chlebowa merged commit 36e72c3 into main Feb 15, 2024
24 checks passed
@chlebowa chlebowa deleted the 635_remove_test_theme@main branch February 15, 2024 15:18
@averissimo
Copy link
Contributor

averissimo commented Feb 19, 2024

Just as a heads up, the linter changes on this PR are not effective as they need to be in the # nolint: <linter_rule>.

The colon : and dot . at the end are fundamental, otherwise, it behaves as # nolint and ignores the following text.

@chlebowa
Copy link
Contributor Author

Really? I was testing them and it seemed to work. Let me have another look.

@chlebowa chlebowa mentioned this pull request Feb 19, 2024
@chlebowa
Copy link
Contributor Author

You're absolutely right!
#638

@averissimo
Copy link
Contributor

You were fast, I was going to pick this up as I don't like saying this kind of thing and then have someone else do the boring job.

@chlebowa
Copy link
Contributor Author

Oh no, I must fix my mistakes myself, thank you for pointing it out 🙂

chlebowa added a commit that referenced this pull request Feb 19, 2024
@chlebowa chlebowa mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Question]: is ggplot2::theme_test() a real theme?
4 participants