-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
635 remove test theme #636
Conversation
Code Coverage Summary
Diff against main
Results for commit: c99a900 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 5 suites 0s ⏱️ Results for commit c99a900. ♻️ This comment has been updated with latest results. |
…eering/teal.modules.general into 635_remove_test_theme@main
This is great, left just one comment, that I think we can over-come quickly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just as a heads up, the linter changes on this PR are not effective as they need to be in the The colon |
Really? I was testing them and it seemed to work. Let me have another look. |
You're absolutely right! |
You were fast, I was going to pick this up as I don't like saying this kind of thing and then have someone else do the boring job. |
Oh no, I must fix my mistakes myself, thank you for pointing it out 🙂 |
Closes #635
Added global variable,
ggplot_themes
, that lists allggplot2
themes in a character vector.ggplot_themes
is used in all calls toselectInput
that present a choice of themes.Removed
"test"
from default arguments that specify initial theme.Trimmed down formal argument descriptions.
Also, restyled the package documentation file to the currently recommended way (
"_PACKAGE"
replaceas@docType package
).Additionally, changed
# nolint
tags to state specific linters that are omitted and removed superfluous#nolint
tags.