Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

options for strict tests; few enhancements #626

Merged
merged 11 commits into from
Mar 18, 2024
Merged

options for strict tests; few enhancements #626

merged 11 commits into from
Mar 18, 2024

Conversation

pawelru
Copy link
Contributor

@pawelru pawelru commented Jan 24, 2024

Please review the changes carefully and let me know if there is something you don't like.

@pawelru pawelru marked this pull request as ready for review January 29, 2024 09:31
Copy link
Contributor

github-actions bot commented Jan 29, 2024

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ------------------------------------
R/tm_a_pca.R                    827     827  0.00%    108-1068
R/tm_a_regression.R             776     776  0.00%    153-1033
R/tm_data_table.R               179     179  0.00%    93-325
R/tm_file_viewer.R              170     170  0.00%    44-248
R/tm_front_page.R               129     118  8.53%    70-222
R/tm_g_association.R            334     334  0.00%    135-541
R/tm_g_bivariate.R              671     411  38.75%   306-771, 812, 923, 940, 958, 969-991
R/tm_g_distribution.R          1042    1042  0.00%    122-1299
R/tm_g_response.R               350     350  0.00%    154-577
R/tm_g_scatterplot.R            726     726  0.00%    230-1057
R/tm_g_scatterplotmatrix.R      282     263  6.74%    165-476, 537, 551
R/tm_missing_data.R            1058    1058  0.00%    92-1304
R/tm_outliers.R                 988     988  0.00%    134-1265
R/tm_t_crosstable.R             255     255  0.00%    141-444
R/tm_variable_browser.R         825     820  0.61%    79-1064, 1102-1286
R/utils.R                        99      96  3.03%    82-267
R/zzz.R                           1       1  0.00%    2
TOTAL                          8712    8414  3.42%

Diff against main

Filename      Stmts    Miss  Cover
----------  -------  ------  --------
TOTAL             0       0  +100.00%

Results for commit: 94e7e0f

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Jan 29, 2024

Unit Tests Summary

 1 files   6 suites   0s ⏱️
29 tests 29 ✅ 0 💤 0 ❌
67 runs  67 ✅ 0 💤 0 ❌

Results for commit 94e7e0f.

♻️ This comment has been updated with latest results.

pawelru and others added 5 commits January 29, 2024 12:07
# Conflicts:
#	DESCRIPTION
#	R/teal.modules.general.R
#	R/tm_a_pca.R
#	R/tm_a_regression.R
#	R/tm_data_table.R
#	R/tm_front_page.R
#	R/tm_g_association.R
#	R/tm_g_bivariate.R
#	R/tm_g_response.R
#	R/tm_g_scatterplot.R
#	R/tm_g_scatterplotmatrix.R
#	R/tm_missing_data.R
#	R/tm_outliers.R
#	R/tm_t_crosstable.R
#	R/tm_variable_browser.R
#	R/utils.R
#	inst/WORDLIST
#	man/call_fun_dots.Rd
#	man/teal.modules.general.Rd
#	man/tm_a_pca.Rd
#	man/tm_a_regression.Rd
#	man/tm_data_table.Rd
#	man/tm_file_viewer.Rd
#	man/tm_front_page.Rd
#	man/tm_g_association.Rd
#	man/tm_g_bivariate.Rd
#	man/tm_g_distribution.Rd
#	man/tm_g_response.Rd
#	man/tm_g_scatterplot.Rd
#	man/tm_g_scatterplotmatrix.Rd
#	man/tm_missing_data.Rd
#	man/tm_outliers.Rd
#	man/tm_t_crosstable.Rd
#	man/tm_variable_browser.Rd
#	man/variable_type_icons.Rd
#	man/varname_w_label.Rd
#	vignettes/teal-modules-general.Rmd
#	vignettes/using-association-plot.Rmd
#	vignettes/using-bivariate-plot.Rmd
#	vignettes/using-cross-table.Rmd
#	vignettes/using-data-table.Rmd
#	vignettes/using-outliers-module.Rmd
#	vignettes/using-regression-plots.Rmd
#	vignettes/using-response-plot.Rmd
#	vignettes/using-scatterplot-matrix.Rmd
#	vignettes/using-scatterplot.Rmd
@vedhav vedhav added the core label Mar 18, 2024
.lintr Outdated Show resolved Hide resolved
Copy link
Contributor

@vedhav vedhav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the .lintr config the changes LGTM! We can merge it after it is resolved.

@pawelru pawelru merged commit 18978fb into main Mar 18, 2024
24 checks passed
@pawelru pawelru deleted the strict_tests branch March 18, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants