-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
options for strict tests; few enhancements #626
Conversation
Code Coverage Summary
Diff against main
Results for commit: 94e7e0f Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 6 suites 0s ⏱️ Results for commit 94e7e0f. ♻️ This comment has been updated with latest results. |
# Conflicts: # DESCRIPTION # R/teal.modules.general.R # R/tm_a_pca.R # R/tm_a_regression.R # R/tm_data_table.R # R/tm_front_page.R # R/tm_g_association.R # R/tm_g_bivariate.R # R/tm_g_response.R # R/tm_g_scatterplot.R # R/tm_g_scatterplotmatrix.R # R/tm_missing_data.R # R/tm_outliers.R # R/tm_t_crosstable.R # R/tm_variable_browser.R # R/utils.R # inst/WORDLIST # man/call_fun_dots.Rd # man/teal.modules.general.Rd # man/tm_a_pca.Rd # man/tm_a_regression.Rd # man/tm_data_table.Rd # man/tm_file_viewer.Rd # man/tm_front_page.Rd # man/tm_g_association.Rd # man/tm_g_bivariate.Rd # man/tm_g_distribution.Rd # man/tm_g_response.Rd # man/tm_g_scatterplot.Rd # man/tm_g_scatterplotmatrix.Rd # man/tm_missing_data.Rd # man/tm_outliers.Rd # man/tm_t_crosstable.Rd # man/tm_variable_browser.Rd # man/variable_type_icons.Rd # man/varname_w_label.Rd # vignettes/teal-modules-general.Rmd # vignettes/using-association-plot.Rmd # vignettes/using-bivariate-plot.Rmd # vignettes/using-cross-table.Rmd # vignettes/using-data-table.Rmd # vignettes/using-outliers-module.Rmd # vignettes/using-regression-plots.Rmd # vignettes/using-response-plot.Rmd # vignettes/using-scatterplot-matrix.Rmd # vignettes/using-scatterplot.Rmd
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the .lintr
config the changes LGTM! We can merge it after it is resolved.
pkg::
from examples for packages in Depends# nolint
from code-docs (e.g. examples or knitr chunks) (this is actually rendered!). I needed to put a higher level exclusion in the top.lintr
file. This is of course more powerful than single line (or code-bloc) exclusionsdontrun{}
teal.modules.general::
from examples and vignettes as this is actually redundant herePlease review the changes carefully and let me know if there is something you don't like.