-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
619 update modules to handle default datanames when datanames = "all" #621
Conversation
Code Coverage Summary
Diff against main
Results for commit: a82091e Minimum allowed coverage is ♻️ This comment has been updated with latest results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add in the modules' documentation that they support data.frames
only. In tm_missing_data
and tm_data_table
there is datasets_selected
argument - I think there should be mentioned that it supports data.frames only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small changes but important i think
this fixes #619
Here, I am filtering
datanames
to only allowdata.frame
class and skipping other classes. Should we notify the user about datanames which are skipped ?