Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

619 update modules to handle default datanames when datanames = "all" #621

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

kartikeyakirar
Copy link
Contributor

this fixes #619

Here, I am filtering datanames to only allow data.frame class and skipping other classes. Should we notify the user about datanames which are skipped ?

Copy link
Contributor

github-actions bot commented Dec 19, 2023

badge

Code Coverage Summary

Filename                      Stmts    Miss  Cover    Missing
--------------------------  -------  ------  -------  ----------------------------------------------
R/tm_a_pca.R                    829     829  0.00%    72-1025
R/tm_a_regression.R             716     716  0.00%    96-895
R/tm_data_table.R               177     177  0.00%    65-291
R/tm_file_viewer.R              172     172  0.00%    42-244
R/tm_front_page.R               129     118  8.53%    66-210
R/tm_g_association.R            332     332  0.00%    92-483
R/tm_g_bivariate.R              655     495  24.43%   128-709, 757, 763, 767, 878, 895, 913, 933-955
R/tm_g_distribution.R          1028    1028  0.00%    122-1272
R/tm_g_response.R               351     351  0.00%    88-503
R/tm_g_scatterplot.R            719     719  0.00%    163-973
R/tm_g_scatterplotmatrix.R      280     261  6.79%    80-377, 431, 445
R/tm_missing_data.R            1054    1054  0.00%    61-1254
R/tm_outliers.R                 976     976  0.00%    78-1183
R/tm_t_crosstable.R             254     254  0.00%    83-375
R/tm_variable_browser.R         823     818  0.61%    65-1296
R/utils.R                       122     122  0.00%    74-351
R/zzz.R                           1       1  0.00%    2
TOTAL                          8618    8423  2.26%

Diff against main

Filename                   Stmts    Miss  Cover
-----------------------  -------  ------  --------
R/tm_data_table.R             +3      +3  +100.00%
R/tm_missing_data.R           +3      +3  +100.00%
R/tm_variable_browser.R       +4      +4  -0.00%
TOTAL                        +10     +10  -0.00%

Results for commit: a82091e

Minimum allowed coverage is 80%

♻️ This comment has been updated with latest results

Copy link
Contributor

github-actions bot commented Dec 19, 2023

Unit Tests Summary

  1 files    5 suites   0s ⏱️
16 tests 16 ✔️ 0 💤 0
49 runs  49 ✔️ 0 💤 0

Results for commit a82091e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add in the modules' documentation that they support data.frames only. In tm_missing_data and tm_data_table there is datasets_selected argument - I think there should be mentioned that it supports data.frames only.

Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small changes but important i think

R/tm_variable_browser.R Show resolved Hide resolved
R/tm_data_table.R Show resolved Hide resolved
@kartikeyakirar kartikeyakirar merged commit e3a6b9a into main Dec 21, 2023
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 619_handle_other_datatype@main branch December 21, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: update modules to handle default datanames when datanames = "all"
2 participants