-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds min package version #538
Conversation
6a40f61
to
9f6c4b8
Compare
Code Coverage Summary
Diff against main
Results for commit: 302ae21 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
I cannot find the following packages in the list. I understand from our previous conversation that some packages are included as part of R, so we don't need to mention them. I just want to confirm that all of the following fall into these categories:
Additionally, I've found some additional entries that have not been imported:
|
@averissimo, I run this check for this branch and its failing. on side note I executed verdepcheck::max_deps_check() locally, but I'm still encountering a pdflatex issue even after installing tinytex. Could you please confirm if I might be overlooking a step here?
|
fd99cb3
to
f672ead
Compare
@kartikeyakirar can you run
ps. I've rebased the branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
checks run successfully https://github.com/insightsengineering/teal.modules.general/actions/runs/6182179703
LGTM 👍
Additionally, I've found some additional entries that have not been imported:
Could you comment on this? before merging this
@kartikeyakirar Nice one for noticing it! I was already going to change the PR, but then saw that those two dependencies are in teal.modules.general/DESCRIPTION Lines 53 to 58 in 1fb3f98
|
@averissimo thanks for explanation. My mistake; I overlooked that part while comparing. |
WIP :: parent issue: insightsengineering/nestdevs-tasks#7
Supersede:
🔴 Checklist for PR Reviewer
main
rmarkdown
(may have been removed onSuggests
)Imports
,Depends
&Suggests
are in new sectionConfig/Needs/verdepcheck
NEWS.md
scheduled.yaml
action was run succesfully (all 4 strategies)Scheduled 🕰️ / Dependency
actionsscheduled.yaml
SHOULD NOT have any push on any branches🔴 What's needed before merging?
This PR depends on some upstream changes that need to be finalized/merged before being ready to review.
Change in code
verdepcheck.yml
action (see comments)on: push
sectionPRS
min_isolated
andmin_cohort
r-verdepcheck-action#16Changes description
DESCRIPTION
Config/Need/verdepcheck
section inDESCRIPTION