1176 remove Show Warnings from modules (#749)

Part of insightsengineering/teal#1176
insightsengineering · May 10, 2024 · bc597d4 · bc597d4
1 parent df33240
commit bc597d4
Show file tree

Hide file tree

Showing 12 changed files with 2 additions and 88 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -1,5 +1,7 @@
 # teal.modules.general 0.3.0.9029
 
+* Removed `Show Warnings` modals from modules.
+
 # teal.modules.general 0.3.0
 
 ### Enhancements

diff --git a/R/tm_a_pca.R b/R/tm_a_pca.R
@@ -282,7 +282,6 @@ ui_a_pca <- function(id, ...) {
         )
       ),
       forms = tagList(
-        teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
         teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
       ),
       pre_output = args$pre_output,
@@ -1033,13 +1032,6 @@ srv_a_pca <- function(id, data, reporter, filter_panel_api, dat, plot_height, pl
       )
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_a_regression.R b/R/tm_a_regression.R
@@ -348,7 +348,6 @@ ui_a_regression <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -1000,13 +999,6 @@ srv_a_regression <- function(id,
       )
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_association.R b/R/tm_g_association.R
@@ -262,7 +262,6 @@ ui_tm_g_association <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -506,13 +505,6 @@ srv_tm_g_association <- function(id,
       teal.code::dev_suppress(output_q()[["title"]])
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_bivariate.R b/R/tm_g_bivariate.R
@@ -431,7 +431,6 @@ ui_g_bivariate <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), button_label = "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -689,13 +688,6 @@ srv_g_bivariate <- function(id,
       width = plot_width
     )
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_distribution.R b/R/tm_g_distribution.R
@@ -333,7 +333,6 @@ ui_distribution <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -1267,13 +1266,6 @@ srv_distribution <- function(id,
       rownames = FALSE
     )
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_response.R b/R/tm_g_response.R
@@ -289,7 +289,6 @@ ui_g_response <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), button_label = "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -547,13 +546,6 @@ srv_g_response <- function(id,
       width = plot_width
     )
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_scatterplot.R b/R/tm_g_scatterplot.R
@@ -466,7 +466,6 @@ ui_g_scatterplot <- function(id, ...) {
         )
       ),
       forms = tagList(
-        teal.widgets::verbatim_popup_ui(ns("warning"), button_label = "Show Warnings"),
         teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
       ),
       pre_output = args$pre_output,
@@ -1022,13 +1021,6 @@ srv_g_scatterplot <- function(id,
       }
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_g_scatterplotmatrix.R b/R/tm_g_scatterplotmatrix.R
@@ -252,7 +252,6 @@ ui_g_scatterplotmatrix <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -441,13 +440,6 @@ srv_g_scatterplotmatrix <- function(id, data, reporter, filter_panel_api, variab
       }
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),

diff --git a/R/tm_missing_data.R b/R/tm_missing_data.R
@@ -228,7 +228,6 @@ srv_page_missing_data <- function(id, data, reporter, filter_panel_api, parent_d
         conditionalPanel(
           is_tab_active_js(ns("dataname_tab"), x),
           tagList(
-            teal.widgets::verbatim_popup_ui(dataname_ns("warning"), "Show Warnings"),
             teal.widgets::verbatim_popup_ui(dataname_ns("rcode"), "Show R code")
           )
         )
@@ -1269,13 +1268,6 @@ srv_missing_data <- function(id, data, reporter, filter_panel_api, dataname, par
       }
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(final_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(final_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(final_q())),

diff --git a/R/tm_outliers.R b/R/tm_outliers.R
@@ -317,7 +317,6 @@ ui_outliers <- function(id, ...) {
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = args$pre_output,
@@ -1219,13 +1218,6 @@ srv_outliers <- function(id, data, reporter, filter_panel_api, outlier_var,
       )
     })
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(final_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(final_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(final_q())),

diff --git a/R/tm_t_crosstable.R b/R/tm_t_crosstable.R
@@ -227,7 +227,6 @@ ui_t_crosstable <- function(id, x, y, show_percentage, show_total, pre_output, p
       )
     ),
     forms = tagList(
-      teal.widgets::verbatim_popup_ui(ns("warning"), "Show Warnings"),
       teal.widgets::verbatim_popup_ui(ns("rcode"), "Show R code")
     ),
     pre_output = pre_output,
@@ -409,13 +408,6 @@ srv_t_crosstable <- function(id, data, reporter, filter_panel_api, label, x, y,
       table_r = table_r
     )
 
-    teal.widgets::verbatim_popup_srv(
-      id = "warning",
-      verbatim_content = reactive(teal.code::get_warnings(output_q())),
-      title = "Warning",
-      disabled = reactive(is.null(teal.code::get_warnings(output_q())))
-    )
-
     teal.widgets::verbatim_popup_srv(
       id = "rcode",
       verbatim_content = reactive(teal.code::get_code(output_q())),