fix: data reactivity in tm_missing_data

insightsengineering · Aug 14, 2024 · 97968df · 97968df
1 parent 74b71af
commit 97968df
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -5,10 +5,13 @@
 ### Enhancements
 * Added `teal.logger` functionality for logging changes in shiny inputs in all modules.
 
+### Bug fixes
+* Fixed a bug in `tm_missing_data` in "Group by Subject" that was not using reactive data call.
+
 # teal.modules.general 0.3.0
 
 ### Enhancements
-* Updated the package docs and vignettes with the new way of specifying data for `teal::init()`. The `data` argument will accept a `teal_data` object
+* Updated the package docs and vignettes with the new way of specifying data for `teal::init()`. The `data` argument will accept a `teal_data` object.
 
 ### Bug fixes
 * Outlier labels no longer appear out of bounds in `tm_a_regression`.

diff --git a/R/tm_missing_data.R b/R/tm_missing_data.R
@@ -464,8 +464,8 @@ srv_missing_data <- function(id, data, reporter, filter_panel_api, dataname, par
 
 
     data_parent_keys <- reactive({
-      if (length(parent_dataname) > 0 && parent_dataname %in% names(data)) {
-        keys <- teal.data::join_keys(data)[[dataname]]
+      if (length(parent_dataname) > 0 && parent_dataname %in% datanames(data())) {
+        keys <- teal.data::join_keys(data())[[dataname]]
         if (parent_dataname %in% names(keys)) {
           keys[[parent_dataname]]
         } else {