507 reevaluate variable_types (#622)

companion to insightsengineering/teal.slice#508 --------- Signed-off-by: Aleksander Chlebowski <[email protected]> Co-authored-by: André Veríssimo <[email protected]>
insightsengineering · Jan 16, 2024 · 77ad143 · 77ad143
1 parent 38ff2b0
commit 77ad143
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 11 deletions.
diff --git a/DESCRIPTION b/DESCRIPTION
@@ -40,7 +40,6 @@ Imports:
     teal.code (>= 0.4.1.9009),
     teal.logger (>= 0.1.1),
     teal.reporter (>= 0.2.0),
-    teal.slice (>= 0.4.0.9028),
     teal.widgets (>= 0.4.0),
     tern (>= 0.7.10),
     tibble (>= 2.0.0),
@@ -75,15 +74,14 @@ Config/Needs/verdepcheck: haleyjeppson/ggmosaic, tidyverse/ggplot2,
     daroczig/logger, tidyverse/magrittr, r-lib/scales, daattali/shinyjs,
     rstudio/shinyvalidate, dreamRs/shinyWidgets, tidyverse/stringr,
     insightsengineering/teal.code, insightsengineering/teal.logger,
-    insightsengineering/teal.reporter, insightsengineering/teal.slice,
-    insightsengineering/teal.transform, insightsengineering/teal.widgets,
-    insightsengineering/tern, tidyverse/tibble, tidyverse/tidyr,
-    r-lib/tidyselect, tidymodels/broom, daattali/colourpicker,
-    daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp, baddstats/goftest,
-    gridExtra, ramnathv/htmlwidgets, jeroen/jsonlite, yihui/knitr,
-    deepayan/lattice, MASS, insightsengineering/nestcolor, r-lib/rlang,
-    insightsengineering/rtables, sparkline, insightsengineering/teal.data,
-    r-lib/testthat
+    insightsengineering/teal.reporter, insightsengineering/teal.transform,
+    insightsengineering/teal.widgets, insightsengineering/tern,
+    tidyverse/tibble, tidyverse/tidyr, r-lib/tidyselect, tidymodels/broom,
+    daattali/colourpicker, daattali/ggExtra, aphalo/ggpmisc, aphalo/ggpp,
+    baddstats/goftest, gridExtra, ramnathv/htmlwidgets, jeroen/jsonlite,
+    yihui/knitr, deepayan/lattice, MASS, insightsengineering/nestcolor,
+    r-lib/rlang, insightsengineering/rtables, sparkline,
+    insightsengineering/teal.data, r-lib/testthat
 Config/Needs/website: insightsengineering/nesttemplate
 Encoding: UTF-8
 Language: en-US

diff --git a/NEWS.md b/NEWS.md
@@ -6,6 +6,7 @@
 
 ### Miscellaneous
 
+* Removed `teal.slice` dependencies.
 * Specified minimal version of package dependencies.
 
 # teal.modules.general 0.2.16

diff --git a/R/tm_variable_browser.R b/R/tm_variable_browser.R
@@ -1189,7 +1189,7 @@ render_tab_table <- function(dataset_name, parent_dataname, output, data, input,
       )
 
       # get icons proper for the data types
-      icons <- stats::setNames(teal.slice:::variable_types(df), colnames(df))
+      icons <- vapply(df, function(x) class(x)[1L], character(1L))
 
       join_keys <- join_keys(data())
       if (!is.null(join_keys)) {