Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add options to tm_t_events for sorting and overall rows #851

Merged
merged 11 commits into from
Dec 1, 2023
Merged

Add options to tm_t_events for sorting and overall rows #851

merged 11 commits into from
Dec 1, 2023

Conversation

edelarua
Copy link
Contributor

Closes #844 #849

@edelarua edelarua added the sme label Nov 16, 2023
@edelarua edelarua linked an issue Nov 16, 2023 that may be closed by this pull request
[Feature Request]: Add option to remove summary rows from tm_t_events #849
Closed
3 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 16, 2023 •
edited
Loading

Unit Tests Summary

    1 files    33 suites   3s ⏱️
149 tests 149 ✔️     0 💤 0 ❌
280 runs  168 ✔️ 112 💤 0 ❌

Results for commit 9991f1d.

♻️ This comment has been updated with latest results.

@chlebowa
Copy link
Contributor

Here's the fix for your example problems: #852

@ayogasekaram ayogasekaram self-requested a review November 22, 2023 19:07
@shajoezhu
Copy link
Contributor

hi @chlebowa and @edelarua

I was trying to test this code example, have teal.data 0.3.0.9016 version. but getting the following errors

Listening on http://127.0.0.1:7218
[INFO] 2023-12-01 06:55:08.2855 pid:3645 token:[b8a46f88] teal Initializing reporter_previewer_module
Warning: Error in : The `data` argument of `get_join_keys()` was deprecated in teal.data 0.3.1 and is now defunct.
ℹ Use `join_keys(data)` instead.
  3: runApp
  2: print.shiny.appobj
  1: <Anonymous>

I was wondering if we having some version issues? Thanks!

@chlebowa
Copy link
Contributor

chlebowa commented Dec 1, 2023

This error happens on this branch but not on main. Perhaps a merge will solve the issue?

shajoezhu
shajoezhu reviewed Dec 1, 2023
View reviewed changes
NEWS.md
Comment on lines -3 to -10
### Enhancements
* Updated the documentation and vignettes to demonstrate method to pass `teal_data` object to `teal::init()`.

### Bug fixes
* Fixed bug in `tm_g_lineplot` forcing module to initialize with a table.

# teal.modules.clinical 0.8.16.9010

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need these back right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Sorry, I’m not sure how the NEWS got mixed up but it should be fixed now :)

shajoezhu
shajoezhu approved these changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks very good! Thanks @edelarua

@edelarua
Fix NEWS
9991f1d 
Signed-off-by: Emily de la Rua <[email protected]>
@edelarua edelarua enabled auto-merge (squash) December 1, 2023 17:15
@edelarua edelarua merged commit 96a0d9f into main Dec 1, 2023
23 checks passed
@edelarua edelarua deleted the 844_sort_option_tm_t_events@main branch December 1, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shajoezhu shajoezhu shajoezhu approved these changes

@ayogasekaram ayogasekaram Awaiting requested review from ayogasekaram

Assignees
No one assigned
Labels
sme
Projects
None yet
Milestone
No milestone
3 participants
@edelarua @chlebowa @shajoezhu