Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1305 allow delayed data to pass in cs_to_des_select #1306

Merged

Conversation

chlebowa
Copy link
Contributor

FIxes #1305

Tested under current CRAN release and development versions:

> packageVersion("teal.transform")
[1] '0.5.0.9018'
> packageVersion("teal.modules.clinical")
[1] '0.9.1.9042'

@chlebowa chlebowa changed the title allow delayed data to pass in cs_to_des_select allow delayed data to pass in cs_to_des_select Dec 18, 2024
Copy link
Contributor

github-actions bot commented Dec 18, 2024

✅ All contributors have signed the CLA
Posted by the CLA Assistant Lite bot.

@chlebowa
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@chlebowa chlebowa changed the title allow delayed data to pass in cs_to_des_select 1305 allow delayed data to pass in cs_to_des_select Dec 18, 2024
@shajoezhu
Copy link
Contributor

shajoezhu commented Dec 19, 2024

image

lgtm! Thanks @chlebowa

I checked everything under the main branch

packageVersion("teal")
[1] ‘0.15.2.9093’
packageVersion("teal.slice")
[1] ‘0.5.1.9019’
packageVersion("teal.logger")
[1] ‘0.3.0.9003’
packageVersion("teal.reporter")
[1] ‘0.3.1.9021’
packageVersion("teal.data")
[1] ‘0.6.0.9023’
packageVersion("teal.code")
[1] ‘0.5.0.9021’

@shajoezhu
Copy link
Contributor

hi @chlebowa , can you please add an entry to the NEWS.md, then this PR is good to go. Thanks a lot!

@chlebowa
Copy link
Contributor Author

Thanks @shajoezhu.

NEWS.md Outdated Show resolved Hide resolved
Signed-off-by: Joe Zhu <[email protected]>
@m7pr m7pr merged commit 9fe4999 into insightsengineering:main Dec 19, 2024
28 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2024
@chlebowa chlebowa deleted the 1305_fix_to_allow_delayed_data branch December 19, 2024 14:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: cs_to_des_select precludes use of teal.transform::all_choices()
3 participants