Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation note about links on r-devel #1299

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Conversation

llrs-roche
Copy link
Contributor

Pull Request

Fixes #1231

The links are correctly resolved to the package and R CMD check doesn't complain (with 2024-12-07 r87428 ucrt)

See insightsengineering/teal#1420 (comment) for a longer explanation.

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Tests Summary

    1 files     70 suites   1h 10m 59s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 984 runs  1 759 ✅ 225 💤 0 ❌

Results for commit 111292f.

♻️ This comment has been updated with latest results.

@m7pr m7pr self-assigned this Dec 11, 2024
@m7pr
Copy link
Contributor

m7pr commented Dec 11, 2024

@llrs-roche you have 2 lintr issues
https://github.com/insightsengineering/teal.modules.clinical/actions/runs/12275600447/job/34250988568?pr=1299#step:7:36
too long lines

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, fix lintr please

Copy link
Contributor

github-actions bot commented Dec 11, 2024

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $756.93$ $-1.14$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💔 $231.74$ $+1.32$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $179.71$ $-1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $271.29$ $-5.19$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $125.29$ $-1.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $199.12$ $+2.24$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💔 $86.92$ $+2.93$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $99.06$ $-1.55$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $79.12$ $-1.75$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $75.39$ $-1.37$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💔 $60.64$ $+1.63$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💔 $89.13$ $+2.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $129.16$ $+1.23$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $57.44$ $+1.89$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $88.95$ $+2.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $60.34$ $-1.33$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $80.47$ $+2.21$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_mmrm 💔 $49.91$ $+1.21$ e2e_tm_a_mmrm_Validate_output_on_different_selection_on_method_t_mmrm_lsmeans.

Results for commit d4b0462

♻️ This comment has been updated with latest results.

@llrs-roche
Copy link
Contributor Author

@llrs-roche llrs-roche enabled auto-merge (squash) December 11, 2024 14:01
@llrs-roche llrs-roche merged commit cb463a7 into main Dec 11, 2024
28 checks passed
@llrs-roche llrs-roche deleted the 1231_man_links@main branch December 11, 2024 16:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

R CMD CHECK note
2 participants