Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use group_var argument to control_lineplot_vars instead of deprecated strata #1223

Merged
merged 5 commits into from
Sep 6, 2024

Conversation

edelarua
Copy link
Contributor

@edelarua edelarua commented Sep 6, 2024

Pull Request

Fixes #1222

@edelarua edelarua enabled auto-merge (squash) September 6, 2024 02:43
Copy link
Contributor

@shajoezhu shajoezhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks @edelarua

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Unit Tests Summary

    1 files     70 suites   1h 6m 12s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 992 runs  1 767 ✅ 225 💤 0 ❌

Results for commit 999b74e.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Sep 6, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 💔 $128.85$ $+1.29$ $0$ $0$ $0$ $0$
shinytest2-tm_a_mmrm 💚 $715.97$ $-4.96$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $228.93$ $-1.36$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $101.56$ $-1.65$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💔 $166.65$ $+5.07$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💔 $61.39$ $+1.81$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💔 $99.01$ $+1.80$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💔 $248.29$ $+4.74$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💔 $115.94$ $+2.00$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💔 $222.35$ $+4.53$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💔 $168.71$ $+2.09$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💔 $61.48$ $+2.35$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💔 $62.44$ $+1.86$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💔 $69.33$ $+1.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💔 $54.16$ $+1.55$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💔 $52.46$ $+1.13$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💔 $120.64$ $+1.17$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💔 $61.75$ $+1.14$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💔 $73.97$ $+1.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💔 $53.41$ $+1.06$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💔 $83.35$ $+1.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💔 $73.70$ $+2.40$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💔 $72.98$ $+2.71$ $0$ $0$ $0$ $0$

Results for commit 8daee58

♻️ This comment has been updated with latest results.

@edelarua edelarua merged commit 3ee96e5 into main Sep 6, 2024
30 checks passed
@edelarua edelarua deleted the 1222_ctrl_lp_vars_deprec@main branch September 6, 2024 21:32
@github-actions github-actions bot locked and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use group_var argument to control_lineplot_vars instead of deprecated strata
2 participants