Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix teal namespace for broken tests #1213

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix teal namespace for broken tests #1213

merged 2 commits into from
Aug 14, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Aug 14, 2024

Fixes the shinytest2 e2e tests failures due to namespace change in the refactor of teal.

@vedhav vedhav added the core label Aug 14, 2024
Copy link
Contributor

github-actions bot commented Aug 14, 2024

Unit Tests Summary

    1 files     70 suites   1h 5m 30s ⏱️
  724 tests   614 ✅ 110 💤 0 ❌
1 992 runs  1 767 ✅ 225 💤 0 ❌

Results for commit 7042ecd.

♻️ This comment has been updated with latest results.

@vedhav vedhav requested a review from averissimo August 14, 2024 14:12
Copy link
Contributor

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $702.22$ $-3.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $224.41$ $-2.57$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $99.66$ $-2.02$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $171.30$ $-5.02$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $259.75$ $-15.52$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $86.69$ $-2.72$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $122.02$ $-4.72$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $228.67$ $-5.73$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💚 $176.19$ $-5.47$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $82.66$ $-4.49$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality 💚 $64.69$ $-1.92$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $67.78$ $-4.30$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $89.70$ $-1.32$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $72.79$ $-3.03$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $69.84$ $-2.23$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💚 $57.48$ $-1.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $87.90$ $-2.68$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💔 $60.57$ $+1.18$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💔 $74.20$ $+3.68$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💔 $56.38$ $+1.39$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $124.44$ $-4.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $86.23$ $-2.43$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $76.09$ $-1.44$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $55.22$ $-1.14$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💚 $76.15$ $-2.50$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💚 $61.96$ $-1.70$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_t_abnormality_by_worst_grade 💚 $11.93$ $-3.00$ e2e_tm_t_abnormality_by_worst_grade_Module_initializes_in_teal_without_errors_and_produces_table_output.

Results for commit 9605d9e

♻️ This comment has been updated with latest results.

@vedhav vedhav enabled auto-merge (squash) August 14, 2024 14:17
Copy link
Contributor

@averissimo averissimo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vedhav vedhav merged commit a112d5c into main Aug 14, 2024
29 checks passed
@vedhav vedhav deleted the fix-ns@main branch August 14, 2024 15:02
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@averissimo averissimo self-assigned this Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants