Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps {rmarkdown} minimal version #1186

Merged
merged 6 commits into from
Jun 11, 2024
Merged

Bumps {rmarkdown} minimal version #1186

merged 6 commits into from
Jun 11, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Part of https://github.com/insightsengineering/coredev-tasks/issues/546

Necessary bump to overcome a lack of binary on ppm snapshots that causes an error on minimum strategies for scheduled workflows.

@averissimo
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@averissimo averissimo marked this pull request as ready for review May 22, 2024 22:18
Copy link
Contributor

github-actions bot commented May 22, 2024

Unit Tests Summary

    1 files     70 suites   1h 11m 55s ⏱️
  720 tests   610 ✅ 110 💤 0 ❌
1 983 runs  1 761 ✅ 222 💤 0 ❌

Results for commit a684e8d.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented May 22, 2024

Unit Test Performance Difference

Test suite performance difference
Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_mmrm 💚 $879.37$ $-7.67$ $0$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 💚 $235.31$ $-7.88$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ci 💚 $107.27$ $-4.89$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 💚 $178.76$ $-6.59$ $0$ $0$ $0$ $0$
shinytest2-tm_g_forest_tte 💚 $68.49$ $-2.70$ $0$ $0$ $0$ $0$
shinytest2-tm_g_ipp 💚 $109.31$ $-6.11$ $0$ $0$ $0$ $0$
shinytest2-tm_g_km 💚 $275.06$ $-9.62$ $0$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 💚 $93.04$ $-3.60$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_adverse_events 💚 $139.34$ $-2.77$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_patient_timeline 💚 $247.38$ $-2.12$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_therapy 💚 $204.95$ $-7.78$ $0$ $0$ $0$ $0$
shinytest2-tm_g_pp_vitals 💚 $83.55$ $-1.57$ $0$ $0$ $0$ $0$
shinytest2-tm_t_abnormality_by_worst_grade 💚 $78.13$ $-1.28$ $0$ $0$ $0$ $0$
shinytest2-tm_t_ancova 💚 $96.45$ $-3.47$ $0$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 💚 $80.39$ $-3.77$ $0$ $0$ $0$ $0$
shinytest2-tm_t_coxreg 💚 $75.72$ $-3.48$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events 💚 $61.73$ $-2.93$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_by_grade 💚 $94.70$ $-5.00$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_patyear 💚 $45.02$ $-2.97$ $0$ $0$ $0$ $0$
shinytest2-tm_t_events_summary 💚 $65.28$ $-3.53$ $0$ $0$ $0$ $0$
shinytest2-tm_t_exposure 💚 $83.36$ $-2.84$ $0$ $0$ $0$ $0$
shinytest2-tm_t_logistic 💚 $60.62$ $-2.46$ $0$ $0$ $0$ $0$
shinytest2-tm_t_mult_events 💚 $58.06$ $-2.57$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_laboratory 💚 $142.31$ $-7.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_medical_history 💚 $68.98$ $-4.01$ $0$ $0$ $0$ $0$
shinytest2-tm_t_pp_prior_medication 💚 $84.64$ $-4.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm 💚 $59.57$ $-2.36$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_arm_by_worst 💚 $93.65$ $-5.02$ $0$ $0$ $0$ $0$
shinytest2-tm_t_shift_by_grade 💚 $84.95$ $-4.66$ $0$ $0$ $0$ $0$
shinytest2-tm_t_smq 💚 $59.35$ $-2.88$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary 💚 $40.73$ $-2.31$ $0$ $0$ $0$ $0$
shinytest2-tm_t_summary_by 💚 $82.40$ $-3.99$ $0$ $0$ $0$ $0$
shinytest2-tm_t_tte 💚 $68.42$ $-3.61$ $0$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_g_barchart_simple 💚 $10.30$ $-1.08$ e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_t_pp_laboratory 💚 $11.95$ $-2.89$ e2e_tm_t_pp_laboratory_Deselection_of_avalu_throws_validation_error.
shinytest2-tm_t_pp_laboratory 💚 $11.75$ $-2.72$ e2e_tm_t_pp_laboratory_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_t_pp_laboratory 💔 $9.43$ $+2.50$ e2e_tm_t_pp_laboratory_Deselection_of_timepoints_throws_validation_error.
shinytest2-tm_t_summary_by 💚 $25.38$ $-1.47$ e2e_tm_t_summary_by_Selecting_arm_var_changes_the_table_and_does_not_throw_validation_errors.

Results for commit bbd2393

♻️ This comment has been updated with latest results.

@averissimo averissimo marked this pull request as draft May 23, 2024 04:14
@averissimo averissimo marked this pull request as ready for review June 11, 2024 07:22
@averissimo
Copy link
Contributor Author

BLUF: This is safe to approve/merge although it's failing all strategies. Once rtables and formatters is released on CRAN it will turn all green

Current version of {tmc} fails on verdepcheck strategies, but it's an expected fail: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/9366914687

Why is it expected:

  • all strategies: {formatters} is a secondary dependency and development version cannot be installed
  • release strategy: rtables it cannot be installed as required version is not on CRAN

Before this changes in dependency version the Scheduled workflow was passing all green: https://github.com/insightsengineering/teal.modules.clinical/actions/runs/9366914687

@averissimo averissimo enabled auto-merge (squash) June 11, 2024 07:26
@averissimo averissimo merged commit b3a4d36 into main Jun 11, 2024
57 of 61 checks passed
@averissimo averissimo deleted the 546-fix-verdepcheck@main branch June 11, 2024 08:41
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants