Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wave 4 - tm_t_binary_outcome shinytests #1155

Merged
merged 6 commits into from
May 7, 2024
Merged

Wave 4 - tm_t_binary_outcome shinytests #1155

merged 6 commits into from
May 7, 2024

Conversation

vedhav
Copy link
Contributor

@vedhav vedhav commented Apr 30, 2024

Part of #1108

@vedhav vedhav added the core label Apr 30, 2024
@vedhav vedhav marked this pull request as draft April 30, 2024 20:56
@vedhav vedhav mentioned this pull request Apr 30, 2024
Closed
42 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

Unit Tests Summary

  1 files   41 suites   16m 24s ⏱️
383 tests 273 ✅ 110 💤 0 ❌
765 runs  543 ✅ 222 💤 0 ❌

Results for commit 91f584f.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 👶 $+121.53$ $+48$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 👶 $+206.89$ $+73$ $0$ $0$ $0$
shinytest2-tm_g_ci 👶 $+98.42$ $+41$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 👶 $+161.79$ $+48$ $0$ $0$ $0$
shinytest2-tm_g_ipp 👶 $+98.78$ $+45$ $0$ $0$ $0$
shinytest2-tm_g_km 👶 $+222.65$ $+80$ $0$ $0$ $0$
shinytest2-tm_t_binary_outcome 👶 $+70.43$ $+38$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_gee 👶 $+7.38$ e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.81$ e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.82$ e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.70$ e2e_tm_a_gee_Deselection_of_cor_struct_does_not_throw_validation_error.
shinytest2-tm_a_gee 👶 $+6.82$ e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.85$ e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.29$ e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.12$ e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee 👶 $+7.34$ e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.87$ e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.31$ e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.55$ e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.67$ e2e_tm_a_gee_Selection_of_id_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.24$ e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee 👶 $+7.70$ e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.44$ e2e_tm_a_gee_Selection_of_visit_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.62$ e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_barchart_simple 👶 $+8.84$ e2e_tm_g_barchart_simple_Changing_barlayout_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.75$ e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.79$ e2e_tm_g_barchart_simple_Changing_facet_scale_x_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.84$ e2e_tm_g_barchart_simple_Changing_facet_scale_y_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.95$ e2e_tm_g_barchart_simple_Changing_flip_axis_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.03$ e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+11.54$ e2e_tm_g_barchart_simple_Changing_rotate_bar_labels_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.90$ e2e_tm_g_barchart_simple_Changing_rotate_x_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.83$ e2e_tm_g_barchart_simple_Changing_rotate_y_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+8.94$ e2e_tm_g_barchart_simple_Changing_show_n_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.12$ e2e_tm_g_barchart_simple_De_selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.37$ e2e_tm_g_barchart_simple_De_selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.59$ e2e_tm_g_barchart_simple_De_selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+7.42$ e2e_tm_g_barchart_simple_Deselection_of_x_throws_validation_error.
shinytest2-tm_g_barchart_simple 👶 $+8.46$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_fill_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+9.05$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_x_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+9.19$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_y_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+6.90$ e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_barchart_simple 👶 $+10.96$ e2e_tm_g_barchart_simple_Selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.96$ e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+10.39$ e2e_tm_g_barchart_simple_Selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+10.27$ e2e_tm_g_barchart_simple_Selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+7.81$ e2e_tm_g_barchart_simple_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_ci 👶 $+6.78$ e2e_tm_g_ci_Deselecting_AVISIT_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.79$ e2e_tm_g_ci_Deselecting_PARAMCD_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+7.06$ e2e_tm_g_ci_Deselecting_color_column_changes_plot_output_and_doesn_t_throw_validation_error.
shinytest2-tm_g_ci 👶 $+7.03$ e2e_tm_g_ci_Deselecting_x_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.86$ e2e_tm_g_ci_Deselecting_y_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.72$ e2e_tm_g_ci_Module_initializes_with_specified_label_x_var_y_var_ADLB_filters_color_conf_level_and_stat.
shinytest2-tm_g_ci 👶 $+7.24$ e2e_tm_g_ci_Selecting_AVISIT_filter_value_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.44$ e2e_tm_g_ci_Selecting_PARAMCD_filter_value_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.40$ e2e_tm_g_ci_Selecting_color_column_changes_plot_output_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.11$ e2e_tm_g_ci_Selecting_confidence_interval_value_changes_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.10$ e2e_tm_g_ci_Selecting_statistic_to_use_changes_a_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.27$ e2e_tm_g_ci_Selecting_x_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.45$ e2e_tm_g_ci_Selecting_y_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+6.18$ e2e_tm_g_ci_example_ci_module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+9.28$ e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.41$ e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+8.23$ e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.66$ e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.34$ e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+7.93$ e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.45$ e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+8.96$ e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+7.41$ e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+8.20$ e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp 👶 $+8.27$ e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.66$ e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.55$ e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+10.66$ e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.26$ e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.42$ e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.77$ e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.31$ e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.11$ e2e_tm_g_ipp_Changing_add_avalu_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.17$ e2e_tm_g_ipp_Changing_add_baseline_hline_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.56$ e2e_tm_g_ipp_Changing_separate_by_obs_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.09$ e2e_tm_g_ipp_Changing_suppress_legend_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+6.86$ e2e_tm_g_ipp_Deselecting_arm_var_column_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.91$ e2e_tm_g_ipp_Deselecting_aval_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.92$ e2e_tm_g_ipp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.88$ e2e_tm_g_ipp_Deselecting_visit_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.23$ e2e_tm_g_ipp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_ipp 👶 $+7.26$ e2e_tm_g_ipp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.29$ e2e_tm_g_ipp_Selecting_aval_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.23$ e2e_tm_g_ipp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.24$ e2e_tm_g_ipp_Selecting_visit_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.03$ e2e_tm_g_ipp_Starts_with_specified_label_parentname_arm_var_paramcd_id_var_visit_var_aval_var_avalu_var_baseline_var_add_baseline_hline_separate_by_obs_suppress_legend_add_avalu.
shinytest2-tm_g_km 👶 $+8.69$ e2e_tm_g_km_Changing_arm_var_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.48$ e2e_tm_g_km_Changing_compare_arms_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.42$ e2e_tm_g_km_Changing_conf_level_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+9.54$ e2e_tm_g_km_Changing_facet_var_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.41$ e2e_tm_g_km_Changing_font_size_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.82$ e2e_tm_g_km_Changing_paramcd_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.36$ e2e_tm_g_km_Changing_pval_method_coxph_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.38$ e2e_tm_g_km_Changing_rel_height_plot_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.33$ e2e_tm_g_km_Changing_show_ci_ribbon_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.14$ e2e_tm_g_km_Changing_show_km_table_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.61$ e2e_tm_g_km_Changing_strata_var_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.29$ e2e_tm_g_km_Changing_ties_coxph_changes_the_plot_without_errors.
shinytest2-tm_g_km 👶 $+8.36$ e2e_tm_g_km_Changing_xlab_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+9.06$ e2e_tm_g_km_Changing_xticks_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.34$ e2e_tm_g_km_Changing_yval_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km 👶 $+8.06$ e2e_tm_g_km_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_km 👶 $+8.67$ e2e_tm_g_km_Deselecting_compare_arms_sets_it_to_FALSE.
shinytest2-tm_g_km 👶 $+7.54$ e2e_tm_g_km_Deselecting_conf_level_throws_validation_error.
shinytest2-tm_g_km 👶 $+7.92$ e2e_tm_g_km_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_km 👶 $+8.25$ e2e_tm_g_km_Deselecting_pval_method_coxph_gives_no_validation_error.
shinytest2-tm_g_km 👶 $+8.73$ e2e_tm_g_km_Deselecting_strata_var_does_not_throw_errors.
shinytest2-tm_g_km 👶 $+8.27$ e2e_tm_g_km_Deselecting_ties_coxph_gives_no_validation_error.
shinytest2-tm_g_km 👶 $+6.99$ e2e_tm_g_km_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_km 👶 $+7.43$ e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.
shinytest2-tm_g_km 👶 $+7.36$ e2e_tm_g_km_Starts_with_specified_collapsed_comparison_settings.
shinytest2-tm_g_km 👶 $+7.44$ e2e_tm_g_km_Starts_with_specified_groups.
shinytest2-tm_g_km 👶 $+7.74$ e2e_tm_g_km_Starts_with_specified_paramcd_aval_var_cnsr_var_facet_var_arm_var_compare_arms_strata_var.
shinytest2-tm_t_binary_outcome 👶 $+6.81$ e2e_tm_t_binary_outcome_Deselection_of_arm_var_variable_throws_validation_error.
shinytest2-tm_t_binary_outcome 👶 $+6.95$ e2e_tm_t_binary_outcome_Deselection_of_paramcd_level_throws_validation_error.
shinytest2-tm_t_binary_outcome 👶 $+6.93$ e2e_tm_t_binary_outcome_Deselection_of_responders_throws_validation_error.
shinytest2-tm_t_binary_outcome 👶 $+7.05$ e2e_tm_t_binary_outcome_Deselection_of_strata_var_variable_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_binary_outcome 👶 $+6.32$ e2e_tm_t_binary_outcome_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_t_binary_outcome 👶 $+7.23$ e2e_tm_t_binary_outcome_Selecting_arm_var_variable_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_binary_outcome 👶 $+7.51$ e2e_tm_t_binary_outcome_Selecting_paramcd_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_binary_outcome 👶 $+7.19$ e2e_tm_t_binary_outcome_Selecting_responders_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_binary_outcome 👶 $+7.10$ e2e_tm_t_binary_outcome_Selecting_strata_var_variable_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_t_binary_outcome 👶 $+7.35$ e2e_tm_t_binary_outcome_Starts_with_specified_label_paramcd_responders_arm_var_buckets_u_diff_ci_u_diff_test_strata_var_s_diff_ci_prop_ci_method_conf_level_aval_var_compare_arms_combine_comp_arms_u_odds_ratio_show_rsp_cat.

Results for commit 8a67073

♻️ This comment has been updated with latest results.

@vedhav vedhav marked this pull request as ready for review May 3, 2024 13:09
@vedhav vedhav force-pushed the 1108_shinytest2_tm_t_binary_outcome@shinytest2@main branch from e80592e to 3ac1647 Compare May 3, 2024 18:31
@kartikeyakirar kartikeyakirar self-assigned this May 6, 2024
@kartikeyakirar
rm arm_var
284aa84
@kartikeyakirar
merge back
91f584f 
Merge branch '1108_shinytest2_tm_t_binary_outcome@shinytest2@main' of https://github.com/insightsengineering/teal.modules.clinical into 1108_shinytest2_tm_t_binary_outcome@shinytest2@main

# Conflicts:
#	tests/testthat/test-shinytest2-tm_t_binary_outcome.R
@kartikeyakirar kartikeyakirar merged commit ef0f711 into shinytest2@main May 7, 2024
26 checks passed
@kartikeyakirar kartikeyakirar deleted the 1108_shinytest2_tm_t_binary_outcome@shinytest2@main branch May 7, 2024 11:18
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kartikeyakirar kartikeyakirar kartikeyakirar approved these changes

Assignees

@kartikeyakirar kartikeyakirar

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vedhav @kartikeyakirar