Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wave 2 - tm_g_lineplot shinytest2 #1137

Merged
merged 13 commits into from
May 1, 2024
Merged

Wave 2 - tm_g_lineplot shinytest2 #1137

merged 13 commits into from
May 1, 2024

Conversation

kartikeyakirar
Copy link
Contributor

Part of #1108

@kartikeyakirar kartikeyakirar marked this pull request as draft April 25, 2024 09:48
@kartikeyakirar kartikeyakirar mentioned this pull request Apr 25, 2024
Closed
42 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Unit Tests Summary

  1 files   40 suites   5s ⏱️
356 tests 150 ✅ 206 💤 0 ❌
488 runs  170 ✅ 318 💤 0 ❌

Results for commit d994d39.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 25, 2024 •
edited
Loading

Unit Test Performance Difference

Test Suite $Status$ Time on main $±Time$ $±Tests$ $±Skipped$ $±Failures$ $±Errors$
shinytest2-tm_a_gee 👶 $+121.58$ $+48$ $0$ $0$ $0$
shinytest2-tm_g_barchart_simple 👶 $+222.79$ $+73$ $0$ $0$ $0$
shinytest2-tm_g_ci 👶 $+99.11$ $+41$ $0$ $0$ $0$
shinytest2-tm_g_forest_rsp 👶 $+164.41$ $+48$ $0$ $0$ $0$
shinytest2-tm_g_ipp 👶 $+114.79$ $+45$ $0$ $0$ $0$
shinytest2-tm_g_lineplot 👶 $+101.38$ $+36$ $0$ $0$ $0$
Additional test case details
Test Suite $Status$ Time on main $±Time$ Test Case
shinytest2-tm_a_gee 👶 $+7.38$ e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.84$ e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.84$ e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.77$ e2e_tm_a_gee_Deselection_of_cor_struct_does_not_throw_validation_error.
shinytest2-tm_a_gee 👶 $+6.78$ e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+6.85$ e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.49$ e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.13$ e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee 👶 $+7.35$ e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.81$ e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee 👶 $+7.33$ e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.72$ e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.65$ e2e_tm_a_gee_Selection_of_id_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.32$ e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee 👶 $+7.35$ e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+7.36$ e2e_tm_a_gee_Selection_of_visit_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee 👶 $+6.60$ e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_barchart_simple 👶 $+9.63$ e2e_tm_g_barchart_simple_Changing_barlayout_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.46$ e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.53$ e2e_tm_g_barchart_simple_Changing_facet_scale_x_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.62$ e2e_tm_g_barchart_simple_Changing_facet_scale_y_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.58$ e2e_tm_g_barchart_simple_Changing_flip_axis_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.91$ e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+12.48$ e2e_tm_g_barchart_simple_Changing_rotate_bar_labels_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.50$ e2e_tm_g_barchart_simple_Changing_rotate_x_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.38$ e2e_tm_g_barchart_simple_Changing_rotate_y_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.59$ e2e_tm_g_barchart_simple_Changing_show_n_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple 👶 $+9.97$ e2e_tm_g_barchart_simple_De_selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+9.18$ e2e_tm_g_barchart_simple_De_selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+9.32$ e2e_tm_g_barchart_simple_De_selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+7.77$ e2e_tm_g_barchart_simple_Deselection_of_x_throws_validation_error.
shinytest2-tm_g_barchart_simple 👶 $+8.89$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_fill_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+9.82$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_x_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+10.21$ e2e_tm_g_barchart_simple_Duplicate_between_x_and_y_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple 👶 $+7.25$ e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_barchart_simple 👶 $+11.60$ e2e_tm_g_barchart_simple_Selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+9.72$ e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+11.12$ e2e_tm_g_barchart_simple_Selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+11.19$ e2e_tm_g_barchart_simple_Selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple 👶 $+8.06$ e2e_tm_g_barchart_simple_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_ci 👶 $+6.83$ e2e_tm_g_ci_Deselecting_AVISIT_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+7.12$ e2e_tm_g_ci_Deselecting_PARAMCD_filter_value_throws_validation_error.
shinytest2-tm_g_ci 👶 $+7.15$ e2e_tm_g_ci_Deselecting_color_column_changes_plot_output_and_doesn_t_throw_validation_error.
shinytest2-tm_g_ci 👶 $+6.91$ e2e_tm_g_ci_Deselecting_x_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.66$ e2e_tm_g_ci_Deselecting_y_var_column_throws_validation_error.
shinytest2-tm_g_ci 👶 $+6.78$ e2e_tm_g_ci_Module_initializes_with_specified_label_x_var_y_var_ADLB_filters_color_conf_level_and_stat.
shinytest2-tm_g_ci 👶 $+7.57$ e2e_tm_g_ci_Selecting_AVISIT_filter_value_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.23$ e2e_tm_g_ci_Selecting_PARAMCD_filter_value_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.30$ e2e_tm_g_ci_Selecting_color_column_changes_plot_output_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.18$ e2e_tm_g_ci_Selecting_confidence_interval_value_changes_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.14$ e2e_tm_g_ci_Selecting_statistic_to_use_changes_a_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci 👶 $+7.57$ e2e_tm_g_ci_Selecting_x_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+7.30$ e2e_tm_g_ci_Selecting_y_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci 👶 $+6.35$ e2e_tm_g_ci_example_ci_module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+9.46$ e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.89$ e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+8.26$ e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.74$ e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.33$ e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+8.17$ e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.90$ e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.13$ e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+7.75$ e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp 👶 $+8.35$ e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp 👶 $+8.23$ e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp 👶 $+9.65$ e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.37$ e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+10.81$ e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.47$ e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.43$ e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.99$ e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp 👶 $+9.49$ e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.61$ e2e_tm_g_ipp_Changing_add_avalu_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+9.13$ e2e_tm_g_ipp_Changing_add_baseline_hline_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.93$ e2e_tm_g_ipp_Changing_separate_by_obs_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.46$ e2e_tm_g_ipp_Changing_suppress_legend_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.52$ e2e_tm_g_ipp_Deselecting_arm_var_column_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+7.59$ e2e_tm_g_ipp_Deselecting_aval_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+7.54$ e2e_tm_g_ipp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+7.72$ e2e_tm_g_ipp_Deselecting_visit_var_throws_validation_error.
shinytest2-tm_g_ipp 👶 $+6.92$ e2e_tm_g_ipp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_ipp 👶 $+9.03$ e2e_tm_g_ipp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.51$ e2e_tm_g_ipp_Selecting_aval_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.54$ e2e_tm_g_ipp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+8.60$ e2e_tm_g_ipp_Selecting_visit_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp 👶 $+7.68$ e2e_tm_g_ipp_Starts_with_specified_label_parentname_arm_var_paramcd_id_var_visit_var_aval_var_avalu_var_baseline_var_add_baseline_hline_separate_by_obs_suppress_legend_add_avalu.
shinytest2-tm_g_lineplot 👶 $+9.47$ e2e_tm_g_lineplot_Deselecting_analysis_variable_throws_validation_error.
shinytest2-tm_g_lineplot 👶 $+9.66$ e2e_tm_g_lineplot_Deselecting_biomarker_throws_validation_error.
shinytest2-tm_g_lineplot 👶 $+9.63$ e2e_tm_g_lineplot_Deselecting_confidence_level_validation_error.
shinytest2-tm_g_lineplot 👶 $+9.59$ e2e_tm_g_lineplot_Deselecting_treatment_variable_throws_validation_error.
shinytest2-tm_g_lineplot 👶 $+8.92$ e2e_tm_g_lineplot_Module_initializes_in_teal_without_errors.
shinytest2-tm_g_lineplot 👶 $+11.10$ e2e_tm_g_lineplot_Selecting_analysis_variable_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_lineplot 👶 $+11.28$ e2e_tm_g_lineplot_Selecting_biomarker_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_lineplot 👶 $+10.89$ e2e_tm_g_lineplot_Selecting_confidence_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_lineplot 👶 $+10.99$ e2e_tm_g_lineplot_Selecting_treatment_variable_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_lineplot 👶 $+9.85$ e2e_tm_g_lineplot_Starts_with_specifiedlabel_param_strata_y_dataset_mid_interval_incl_screenplot_settings_and_table_settings

Results for commit 062c35a

♻️ This comment has been updated with latest results.

@gogonzo gogonzo self-assigned this Apr 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 30, 2024 •
edited
Loading

CLA Assistant Lite bot ✅ All contributors have signed the CLA

@kartikeyakirar kartikeyakirar marked this pull request as ready for review April 30, 2024 07:06
@kartikeyakirar
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

gogonzo
gogonzo reviewed Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add check for x variable (fixed default value) - as commented below

tests/testthat/test-shinytest2-tm_g_lineplot.R Outdated Show resolved Hide resolved
gogonzo
gogonzo approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@gogonzo gogonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good. Please address comments and merge afterwards

@kartikeyakirar kartikeyakirar merged commit aad3af7 into shinytest2@main May 1, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 1108_shinytest2_tm_g_lineplot@shinytest2@main branch May 1, 2024 09:14
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gogonzo gogonzo gogonzo approved these changes

Assignees

@gogonzo gogonzo

Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kartikeyakirar @gogonzo @averissimo