Wave 2 - `tm_g_km` shinytests #1133

m7pr · 2024-04-23T13:54:04Z

Part of #1108

…2@main

…hub.com/insightsengineering/teal.modules.clinical into 1108_shinytest2_tm_g_km@shinytest2@main

…2@main

github-actions · 2024-04-25T14:07:04Z

Unit Tests Summary

1 files 40 suites 16m 43s ⏱️
373 tests 263 ✅ 110 💤 0 ❌
727 runs 505 ✅ 222 💤 0 ❌

Results for commit 3e6c570.

♻️ This comment has been updated with latest results.

github-actions · 2024-04-25T14:07:09Z

Unit Test Performance Difference

Test Suite	$Status$	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	👶	$+122.23$	$+48$	$0$	$0$	$0$
shinytest2-tm_g_barchart_simple	👶	$+225.51$	$+73$	$0$	$0$	$0$
shinytest2-tm_g_ci	👶	$+102.69$	$+41$	$0$	$0$	$0$
shinytest2-tm_g_forest_rsp	👶	$+171.88$	$+48$	$0$	$0$	$0$
shinytest2-tm_g_ipp	👶	$+120.71$	$+45$	$0$	$0$	$0$
shinytest2-tm_g_km	👶	$+255.66$	$+80$	$0$	$0$	$0$

Additional test case details

Test Suite	$Status$	$±Time$	Test Case
shinytest2-tm_a_gee	👶	$+7.45$	e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+6.99$	e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee	👶	$+6.85$	e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee	👶	$+6.76$	e2e_tm_a_gee_Deselection_of_cor_struct_does_not_throw_validation_error.
shinytest2-tm_a_gee	👶	$+6.85$	e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee	👶	$+6.98$	e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee	👶	$+7.44$	e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee	👶	$+7.17$	e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee	👶	$+7.40$	e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+6.95$	e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee	👶	$+7.47$	e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+7.57$	e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+7.66$	e2e_tm_a_gee_Selection_of_id_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+7.25$	e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee	👶	$+7.38$	e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+7.42$	e2e_tm_a_gee_Selection_of_visit_var_does_not_change_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶	$+6.62$	e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_barchart_simple	👶	$+9.49$	e2e_tm_g_barchart_simple_Changing_barlayout_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.46$	e2e_tm_g_barchart_simple_Changing_expand_y_range_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.91$	e2e_tm_g_barchart_simple_Changing_facet_scale_x_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.57$	e2e_tm_g_barchart_simple_Changing_facet_scale_y_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.51$	e2e_tm_g_barchart_simple_Changing_flip_axis_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.98$	e2e_tm_g_barchart_simple_Changing_label_bars_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+12.97$	e2e_tm_g_barchart_simple_Changing_rotate_bar_labels_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.69$	e2e_tm_g_barchart_simple_Changing_rotate_x_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.62$	e2e_tm_g_barchart_simple_Changing_rotate_y_label_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+9.73$	e2e_tm_g_barchart_simple_Changing_show_n_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_barchart_simple	👶	$+10.30$	e2e_tm_g_barchart_simple_De_selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+9.45$	e2e_tm_g_barchart_simple_De_selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+9.28$	e2e_tm_g_barchart_simple_De_selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+7.92$	e2e_tm_g_barchart_simple_Deselection_of_x_throws_validation_error.
shinytest2-tm_g_barchart_simple	👶	$+8.86$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_fill_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶	$+9.95$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_x_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶	$+10.00$	e2e_tm_g_barchart_simple_Duplicate_between_x_and_y_facet_selection_throws_validation_error
shinytest2-tm_g_barchart_simple	👶	$+7.43$	e2e_tm_g_barchart_simple_Module_initializes_in_teal_without_errors_and_produces_output.
shinytest2-tm_g_barchart_simple	👶	$+11.93$	e2e_tm_g_barchart_simple_Selection_of_fill_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+9.72$	e2e_tm_g_barchart_simple_Selection_of_x_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+11.49$	e2e_tm_g_barchart_simple_Selection_of_x_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+11.13$	e2e_tm_g_barchart_simple_Selection_of_y_facet_dataset_changes_the_element_and_does_not_throw_validation_errors
shinytest2-tm_g_barchart_simple	👶	$+8.13$	e2e_tm_g_barchart_simple_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.
shinytest2-tm_g_ci	👶	$+7.14$	e2e_tm_g_ci_Deselecting_AVISIT_filter_value_throws_validation_error.
shinytest2-tm_g_ci	👶	$+7.23$	e2e_tm_g_ci_Deselecting_PARAMCD_filter_value_throws_validation_error.
shinytest2-tm_g_ci	👶	$+7.49$	e2e_tm_g_ci_Deselecting_color_column_changes_plot_output_and_doesn_t_throw_validation_error.
shinytest2-tm_g_ci	👶	$+7.09$	e2e_tm_g_ci_Deselecting_x_var_column_throws_validation_error.
shinytest2-tm_g_ci	👶	$+7.35$	e2e_tm_g_ci_Deselecting_y_var_column_throws_validation_error.
shinytest2-tm_g_ci	👶	$+6.89$	e2e_tm_g_ci_Module_initializes_with_specified_label_x_var_y_var_ADLB_filters_color_conf_level_and_stat.
shinytest2-tm_g_ci	👶	$+7.44$	e2e_tm_g_ci_Selecting_AVISIT_filter_value_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶	$+7.68$	e2e_tm_g_ci_Selecting_PARAMCD_filter_value_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶	$+7.63$	e2e_tm_g_ci_Selecting_color_column_changes_plot_output_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶	$+7.50$	e2e_tm_g_ci_Selecting_confidence_interval_value_changes_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci	👶	$+7.43$	e2e_tm_g_ci_Selecting_statistic_to_use_changes_a_plot_and_doesn_t_throw_any_errors.
shinytest2-tm_g_ci	👶	$+7.55$	e2e_tm_g_ci_Selecting_x_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶	$+7.70$	e2e_tm_g_ci_Selecting_y_var_column_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ci	👶	$+6.59$	e2e_tm_g_ci_example_ci_module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	👶	$+9.92$	e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+9.92$	e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+8.64$	e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶	$+9.52$	e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶	$+9.01$	e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶	$+8.85$	e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶	$+9.94$	e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+9.70$	e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+7.82$	e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	👶	$+8.57$	e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp	👶	$+8.81$	e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶	$+9.89$	e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+9.82$	e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+11.29$	e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+10.01$	e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+10.16$	e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+10.09$	e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶	$+9.91$	e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+8.92$	e2e_tm_g_ipp_Changing_add_avalu_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+9.49$	e2e_tm_g_ipp_Changing_add_baseline_hline_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+9.40$	e2e_tm_g_ipp_Changing_separate_by_obs_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+9.05$	e2e_tm_g_ipp_Changing_suppress_legend_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+8.04$	e2e_tm_g_ipp_Deselecting_arm_var_column_throws_validation_error.
shinytest2-tm_g_ipp	👶	$+7.92$	e2e_tm_g_ipp_Deselecting_aval_var_throws_validation_error.
shinytest2-tm_g_ipp	👶	$+7.89$	e2e_tm_g_ipp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_ipp	👶	$+7.93$	e2e_tm_g_ipp_Deselecting_visit_var_throws_validation_error.
shinytest2-tm_g_ipp	👶	$+7.54$	e2e_tm_g_ipp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_ipp	👶	$+9.06$	e2e_tm_g_ipp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+9.19$	e2e_tm_g_ipp_Selecting_aval_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+9.12$	e2e_tm_g_ipp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+8.98$	e2e_tm_g_ipp_Selecting_visit_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_ipp	👶	$+8.18$	e2e_tm_g_ipp_Starts_with_specified_label_parentname_arm_var_paramcd_id_var_visit_var_aval_var_avalu_var_baseline_var_add_baseline_hline_separate_by_obs_suppress_legend_add_avalu.
shinytest2-tm_g_km	👶	$+10.07$	e2e_tm_g_km_Changing_arm_var_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.80$	e2e_tm_g_km_Changing_compare_arms_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.90$	e2e_tm_g_km_Changing_conf_level_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+11.15$	e2e_tm_g_km_Changing_facet_var_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.98$	e2e_tm_g_km_Changing_font_size_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+10.42$	e2e_tm_g_km_Changing_paramcd_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.91$	e2e_tm_g_km_Changing_pval_method_coxph_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.87$	e2e_tm_g_km_Changing_rel_height_plot_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+10.22$	e2e_tm_g_km_Changing_show_ci_ribbon_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+9.69$	e2e_tm_g_km_Changing_show_km_table_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+10.00$	e2e_tm_g_km_Changing_strata_var_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+10.07$	e2e_tm_g_km_Changing_ties_coxph_changes_the_plot_without_errors.
shinytest2-tm_g_km	👶	$+9.59$	e2e_tm_g_km_Changing_xlab_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+10.86$	e2e_tm_g_km_Changing_xticks_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+9.77$	e2e_tm_g_km_Changing_yval_changes_the_plot_and_does_not_throw_validation_errors.
shinytest2-tm_g_km	👶	$+8.34$	e2e_tm_g_km_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_km	👶	$+9.93$	e2e_tm_g_km_Deselecting_compare_arms_sets_it_to_FALSE.
shinytest2-tm_g_km	👶	$+7.83$	e2e_tm_g_km_Deselecting_conf_level_throws_validation_error.
shinytest2-tm_g_km	👶	$+8.34$	e2e_tm_g_km_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_km	👶	$+9.82$	e2e_tm_g_km_Deselecting_pval_method_coxph_gives_no_validation_error.
shinytest2-tm_g_km	👶	$+10.00$	e2e_tm_g_km_Deselecting_strata_var_does_not_throw_errors.
shinytest2-tm_g_km	👶	$+9.80$	e2e_tm_g_km_Deselecting_ties_coxph_gives_no_validation_error.
shinytest2-tm_g_km	👶	$+7.80$	e2e_tm_g_km_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_km	👶	$+8.37$	e2e_tm_g_km_Starts_with_specified_collapsed_additional_plot_settings.
shinytest2-tm_g_km	👶	$+7.83$	e2e_tm_g_km_Starts_with_specified_collapsed_comparison_settings.
shinytest2-tm_g_km	👶	$+8.12$	e2e_tm_g_km_Starts_with_specified_groups.
shinytest2-tm_g_km	👶	$+8.17$	e2e_tm_g_km_Starts_with_specified_paramcd_aval_var_cnsr_var_facet_var_arm_var_compare_arms_strata_var.

Results for commit 3032024

♻️ This comment has been updated with latest results.

averissimo

I think you can simplify the tests by using a reusable function.

tests/testthat/test-shinytest2-tm_g_km.R

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

m7pr · 2024-04-26T11:02:00Z

Thanks @averissimo - appreciate the simplification of the reusable function

…2@main

m7pr · 2024-04-26T12:43:53Z

── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'xticks' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'yval' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'font_size' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'rel_height_plot' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'show_ci_ribbon' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'show_km_table' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'conf_level' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"
  ── Error ('test-shinytest2-tm_g_km.R:359:7'): e2e - tm_g_km: Changing 'xlab' changes the plot and does not throw validation errors. ──
  Error in `setup_fun(app_driver)`: could not find function "setup_fun"

oh wow :D

…hub.com/insightsengineering/teal.modules.clinical into 1108_shinytest2_tm_g_km@shinytest2@main

…2@main Signed-off-by: Marcin <[email protected]>

m7pr · 2024-04-26T14:13:28Z

Hey @averissimo I did fix tests locally. They are running on CI now. Let me know if you see any other imprvoements. If not, team feel free to merge, if I'm off

github-actions · 2024-04-30T12:01:32Z

CLA Assistant Lite bot:
🎉 Thank you for your contribution! Before this PR can be accepted, we require that you all read and agree to our Contributor License Agreement.
You can digitally sign the CLA by posting a comment on this Pull Request in the format shown below. This agreement will apply to this PR as well as all future contributions on this repository.

I have read the CLA Document and I hereby sign the CLA

2 out of 3 committers have signed the CLA.
✅ (averissimo)[https://github.com/averissimo]
✅ (vedhav)[https://github.com/vedhav]
❌ @m7pr
_{You can retrigger this bot by commenting recheck in this Pull Request}

vedhav

👌🏽

…2@main

init for tm_g_km

bc9165a

m7pr added the core label Apr 23, 2024

m7pr changed the title ~~Wave 2 - tm g km shinytests~~ Wave 2 - tm_g_km shinytests Apr 23, 2024

m7pr added 6 commits April 24, 2024 11:19

there's gonna be ne method for plots output : )

5d227b5

initial tests

38f2c61

remove whiteline

42a19aa

test for groups

16dcdc0

tests for collapsed comparison settings

82f8fcf

tests for specified collapsed additional plot settings.

f78af06

m7pr mentioned this pull request Apr 24, 2024

Implement shinytest2 for tmc #1108

Closed

42 tasks

empty test

ecd556d

m7pr changed the base branch from main to shinytest2@main April 24, 2024 12:30

m7pr and others added 9 commits April 24, 2024 14:30

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

55b0b8d

…2@main

Merge branch '1108_shinytest2_tm_g_km@shinytest2@main' of https://git…

c2d85a6

…hub.com/insightsengineering/teal.modules.clinical into 1108_shinytest2_tm_g_km@shinytest2@main

tests for encoding variables

f9bd441

move tests around

edd0f24

tests for comparison settings

1842402

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

5ab5895

…2@main

tests for changing of additional plot settings

373bdd8

deselection messages

b5d7682

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

f10b735

…2@main

m7pr marked this pull request as ready for review April 25, 2024 13:48

averissimo self-assigned this Apr 25, 2024

fix: linter hanging indentation

b7b8414

averissimo reviewed Apr 26, 2024

View reviewed changes

tests/testthat/test-shinytest2-tm_g_km.R Outdated Show resolved Hide resolved

tests/testthat/test-shinytest2-tm_g_km.R Outdated Show resolved Hide resolved

m7pr and others added 2 commits April 26, 2024 12:59

Update tests/testthat/test-shinytest2-tm_g_km.R

c3a99dc

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

Update tests/testthat/test-shinytest2-tm_g_km.R

b6cc1a9

Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Marcin <[email protected]>

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

0b61144

…2@main

m7pr and others added 7 commits April 26, 2024 14:46

Merge branch '1108_shinytest2_tm_g_km@shinytest2@main' of https://git…

295b1fc

…hub.com/insightsengineering/teal.modules.clinical into 1108_shinytest2_tm_g_km@shinytest2@main

fix tests

8967ce6

use ns_des_input

88bca3d

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

0f9ef09

…2@main Signed-off-by: Marcin <[email protected]>

add whiteline

d3ff04f

use ns_des_input

d4597ab

other way around

d35c593

vedhav assigned vedhav and unassigned averissimo Apr 30, 2024

chore: standardise some of the tests

43d9598

vedhav approved these changes Apr 30, 2024

View reviewed changes

vedhav and others added 2 commits April 30, 2024 18:10

Merge branch 'shinytest2@main' into 1108_shinytest2_tm_g_km@shinytest…

4b410f1

…2@main

chore: remove extra tests

3e6c570

vedhav merged commit 8587368 into shinytest2@main Apr 30, 2024
25 of 26 checks passed

vedhav deleted the 1108_shinytest2_tm_g_km@shinytest2@main branch April 30, 2024 14:02

github-actions bot locked and limited conversation to collaborators Apr 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Wave 2 - `tm_g_km` shinytests #1133

Wave 2 - `tm_g_km` shinytests #1133

m7pr commented Apr 23, 2024

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

averissimo left a comment

m7pr commented Apr 26, 2024

m7pr commented Apr 26, 2024

m7pr commented Apr 26, 2024

github-actions bot commented Apr 30, 2024 •

edited

Loading

vedhav left a comment

Wave 2 - tm_g_km shinytests #1133

Wave 2 - tm_g_km shinytests #1133

Conversation

m7pr commented Apr 23, 2024

github-actions bot commented Apr 25, 2024 • edited Loading

Unit Tests Summary

github-actions bot commented Apr 25, 2024 • edited Loading

Unit Test Performance Difference

averissimo left a comment

Choose a reason for hiding this comment

m7pr commented Apr 26, 2024

m7pr commented Apr 26, 2024

m7pr commented Apr 26, 2024

github-actions bot commented Apr 30, 2024 • edited Loading

vedhav left a comment

Choose a reason for hiding this comment

Wave 2 - `tm_g_km` shinytests #1133

Wave 2 - `tm_g_km` shinytests #1133

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 25, 2024 •

edited

Loading

github-actions bot commented Apr 30, 2024 •

edited

Loading