-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incrementally initializing the test apps so it becomes easier to review the tests. #1132
Conversation
@vedhav we start the test description with a capital letter, and end with a dot "e2e - tm_a_pca: Module is initialised with the specified defaults in function call." |
App drivers are only initialized for 9/30 modules. |
@vedhav if there is one module only, do not use |
Hey, when it comes for the motivation why this PR is not necessary - I just started with |
I think you have |
|
||
testthat::expect_match( | ||
app_driver$get_attr( | ||
app_driver$active_module_element("myplot-plot_main > img"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is stupid but ui_g_adverse_events
uses teal.widgets::plot_with_settings_ui(id = ns("chart"))
app_driver$active_module_element("myplot-plot_main > img"), | |
app_driver$active_module_element("chart-plot_main > img"), |
Checkout the discussion about discrepancy in plot namespace name in here : ) insightsengineering/teal#1208 (comment)
|
||
testthat::expect_match( | ||
app_driver$get_attr( | ||
app_driver$active_module_element("myplot-plot_main > img"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same reasoning as here https://github.com/insightsengineering/teal.modules.clinical/pull/1132/files#r1576318046
IMHO it would be better if we can go module by module, so we can focus on one module and catch such things.
app_driver$active_module_element("myplot-plot_main > img"), | |
app_driver$active_module_element("patient_timeline_plot-plot_main > img"), |
|
||
testthat::expect_match( | ||
app_driver$get_attr( | ||
app_driver$active_module_element("myplot-plot_main > img"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app_driver$active_module_element("myplot-plot_main > img"), | |
app_driver$active_module_element("therapy_plot-plot_main > img"), |
|
||
testthat::expect_match( | ||
app_driver$get_attr( | ||
app_driver$active_module_element("myplot-plot_main > img"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app_driver$active_module_element("myplot-plot_main > img"), | |
app_driver$active_module_element("vitals_plot-plot_main > img"), |
Closing the PR as we have independent PRs raised |
Part of #1108