Wave 1 - tm_g_forest_rsp shinytests

[vedhav]

Part of #1108

[github-actions]

Unit Tests Summary

  1 files   35 suites   4s ⏱️
278 tests 150 ✅ 128 💤 0 ❌
410 runs  170 ✅ 240 💤 0 ❌

Results for commit c1a546d.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_g_forest_rsp	👶		$+0.22$	$+18$	$+18$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Changing_font_size_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Changing_rel_width_forest_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_arm_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_conf_level_or_selecting_outside_the_range_of_0_1_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_paramcd_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_responders_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Deselecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.02$	e2e_tm_g_forest_rsp_Module_initializes_in_teal_without_errors_and_produces_plot_output.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Module_initializes_with_specified_label_arm_var_paramcd_aval_var_responders_subgroup_var_strata_var_conf_level_fixed_symbol_size_rel_width_forest_font_size.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_a_non_factors_column_in_subgroup_var_throws_validation_error.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_arm_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_conf_level_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_paramcd_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_responders_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_strata_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Selecting_subgroup_var_changes_plot_and_doesn_t_throw_validation_errors.
shinytest2-tm_g_forest_rsp	👶		$+0.01$	e2e_tm_g_forest_rsp_Unsetting_fixed_symbol_size_changes_plot_and_doesn_t_throw_validation_errors.

Results for commit d0ef1a0

♻️ This comment has been updated with latest results.

[gogonzo]

Not all encoding panel settings are covered by tests. aval_var completely missing. Only some negative scenarios are included

paramcd:
  - defaults ✅ 
  - selecting changes plot
  - "Please select Endpoint filter."  ✅
aval_var:
  - defaults
  - selecting changes plot
  - "An analysis variable is required"
responders:
  - defaults ✅ 
  - selecting changes plot
  - "`Responders` field is empty" ✅
arm_var:
  - defaults ✅ 
  - selecting changes plot
  - "A treatment variable is required" ✅
arm_buckets:
  - defaults
  - selecting changes plot
subgroup_var:
  - defaults ✅ 
  - selecting/deselecting changes plot ✅
strata_var:
  - defaults ✅
  - selecting/deselecting changes plot ✅
conf_level:
  - defaults ✅
  - selecting changes plot
  - "Please choose a confidence level between 0 and 1"
  - "Please choose a confidence level between {left} and {right}"
fixed_symbol_size:
  - defaults ✅
  - selecting changes plot
rel_with_forest:
  - defaults
  - selecting changes plot
font_size:
  - defaults ✅
  - selecting changes plot

[m7pr]

@vedhav for active_module_pws_output you will be able to use new method insightsengineering/teal#1208
and please extend tests to verify that content of the plot changes based on selection of inputs

[m7pr]

@vedhav you should be ready to get since $get_active_module_pws_input() method is merged to teal insightsengineering/teal#1208

[gogonzo]

Thanks for update. Still missing tests of the "responders" and "rel_width_forest". There is a non-trivial "responders" update logic based on aval and paramcd.

[vedhav]

Added tests for responders on fa7250e. I think rel_width_forest already has tests.

[m7pr]

@vedhav I know this is minor, but can you put dots at the end of descriptions of tests : P ?

[vedhav]

@vedhav I know this is minor, but can you put dots at the end of descriptions of tests : P ?

Sure thing. I did not see them in @gogonzo's PR too so I wanted to wait a bit. Did not want to add them and remove them again. I'll add them now 🤞🏽

[gogonzo]

I'm fine with this PR now.

[gogonzo]

👍