Wave 1 - tm_a_gee shinytests

[m7pr]

Part of #1108

We can move active_module_tws_output to be a method of teal:::TealAppDriver

[github-actions]

Unit Tests Summary

  1 files   35 suites   4s ⏱️
278 tests 150 ✅ 128 💤 0 ❌
410 runs  170 ✅ 240 💤 0 ❌

Results for commit 8beef7f.

♻️ This comment has been updated with latest results.

[github-actions]

Unit Test Performance Difference

Test Suite	$Status$	Time on main	$±Time$	$±Tests$	$±Skipped$	$±Failures$	$±Errors$
shinytest2-tm_a_gee	👶		$+0.22$	$+18$	$+18$	$0$	$0$

Additional test case details

Test Suite	$Status$	Time on main	$±Time$	Test Case
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Change_in_arm_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_arm_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_conf_level_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_cor_struct_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_cov_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_id_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_paramcd_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Deselection_of_visit_var_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.02$	e2e_tm_a_gee_Module_initializes_in_teal_without_errors_and_produces_table_output.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_conf_level_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_conf_level_out_of_0_1_range_throws_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_cor_struct_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_cov_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_id_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_output_table_changes_the_table_and_doesn_t_throw_validation_error.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_paramcd_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Selection_of_visit_var_changes_the_table_and_does_not_throw_validation_errors.
shinytest2-tm_a_gee	👶		$+0.01$	e2e_tm_a_gee_Starts_with_specified_label_id_var_arm_var_visit_var_paramcd_cov_var_conf_level_and_conf_struct.

Results for commit c7b7432

♻️ This comment has been updated with latest results.

[gogonzo]

Below, list of encoding inputs and what would be nice to test. Some of the actions on the server side are missing (see those without check mark)

aval_var:
  - default ✅ 
  - selecting changes table
  - "An analysis variable is required"
paramcd:
  - default ✅
  - selecting changes table ✅
  - "An endpoint is required" ✅
visit_var:
  - default  ✅
  - selecting changes table ✅
  - "A visit variable is required" ✅
cov_var:
  - default ✅
  - selecting changes table ✅
  - deselecting ✅
split_covariates:
  - default
  - selecting changes table
  - updated when cov_var is changed
arm_var:
  - default ✅
  - selecting changes table ✅
  - "A treatment variable is required" ✅
id_var:
  - default ✅ 
  - selecting changes table ✅
  - "A Subject identifier is required" ✅
cor_struct:
  - default
  - selecting changes table
  - "Please choose a correlation structure"
conf_level:
  - default ✅
  - selecting changes table ✅
  - "Please choose a confidence level."
  - "Confidence level must be between 0 and 1"
output_type:
  - default  ✅ (but choices instead)
  - selecting changes table  ✅

[m7pr]

Hey @gogonzo thanks for the review and the analysis - aval_var is fixed and there is no way to check selection and validate the error on empty selection

aval_var:
  - default ✅ 
  - selecting changes table
  - "An analysis variable is required"

OK 👍

[m7pr]

Hey @gogonzo I added few tests as you recommend and replied to your great list in a print-screen below

[gogonzo]

Well covered 👍 Let's wait for pws/tws methods in teal

[gogonzo]

👍