Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

52 standardise optional notation #1094

Merged
merged 4 commits into from
Mar 14, 2024
Merged

Conversation

kartikeyakirar
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Mar 5, 2024

Unit Tests Summary

  1 files   33 suites   3s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 8ff11af.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@m7pr m7pr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kartikeyakirar can you remove commas in between a combination of optional a noun, and then re-assign for me to do a review?

@m7pr m7pr self-assigned this Mar 14, 2024
@kartikeyakirar kartikeyakirar requested a review from m7pr March 14, 2024 13:35
@kartikeyakirar kartikeyakirar merged commit 3bf14e4 into main Mar 14, 2024
24 checks passed
@kartikeyakirar kartikeyakirar deleted the 52_standardise_optional@main branch March 14, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants