Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of # nolint comments #1091

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Cleanup of # nolint comments #1091

merged 2 commits into from
Mar 1, 2024

Conversation

averissimo
Copy link
Contributor

Pull Request

Fixes #1090

Changes description

  • Adds object_name rule that is friendly to variables with CDISC dataset names and ANL variables
  • Converts all # nolint comments to specific rules
  • Removes unnecessary # nolint comments
  • Corrects indentation in code (that removes indentation_linter rule from .lintr)

@averissimo averissimo added the core label Mar 1, 2024
@averissimo averissimo requested review from chlebowa and removed request for chlebowa March 1, 2024 11:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 1, 2024 •
edited
Loading

Unit Tests Summary

  1 files   33 suites   2s ⏱️
150 tests 150 ✅   0 💤 0 ❌
282 runs  170 ✅ 112 💤 0 ❌

Results for commit 224d539.

♻️ This comment has been updated with latest results.

chlebowa
chlebowa approved these changes Mar 1, 2024
View reviewed changes
Copy link
Contributor

@chlebowa chlebowa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👌

R/tm_t_abnormality_by_worst_grade.R Outdated Show resolved Hide resolved
R/tm_t_shift_by_arm.R Show resolved Hide resolved
@averissimo averissimo merged commit fc6f4ec into main Mar 1, 2024
24 checks passed
@averissimo averissimo deleted the 1090-lintr@main branch March 1, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chlebowa chlebowa chlebowa approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Cleanup]: Remove unnecessary linter exceptions and update .lintr
2 participants
@averissimo @chlebowa