Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShinyValidate #688

Closed
36 tasks done
Tracked by #57
nikolas-burkoff opened this issue Nov 23, 2022 · 2 comments · Fixed by #699
Closed
36 tasks done
Tracked by #57

ShinyValidate #688

nikolas-burkoff opened this issue Nov 23, 2022 · 2 comments · Fixed by #699
Assignees
Labels

Comments

@nikolas-burkoff
Copy link
Contributor

nikolas-burkoff commented Nov 23, 2022

Replace validate statements with shinyvalidate

See insightsengineering/teal.osprey#185 to make sure we get helpful messages

@nikolas-burkoff
Copy link
Contributor Author

So be aware of work being done here to allow data_extract_spec to be included in shinyvalidate.

As tmc uses cs_to_des instead of des directly like tmg - it shouldn't be too hard to add simple validation such as required 🙏

@donyunardi
Copy link
Contributor

donyunardi commented Dec 1, 2022

Acceptance Criteria

  • Implement shinyvalidate (and remove validate) from tmc.
  • Utilize the validate_inputs technique from teal if possible.
  • Apply to 36 modules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants