Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement shinyvalidate in the repositories #57

Closed
6 tasks done
gogonzo opened this issue Jul 1, 2022 · 0 comments
Closed
6 tasks done

Implement shinyvalidate in the repositories #57

gogonzo opened this issue Jul 1, 2022 · 0 comments
Labels
core

Comments

@gogonzo
Copy link

gogonzo commented Jul 1, 2022 •
edited by donyunardi
Loading

Research

https://github.com/insightsengineering/coredev-tasks/issues/230

Conclusion

Apply shinyvalidate on teal.osprey first

Address any issue or improvement in teal.osprey:

Move to implementation to other modules packages once everything is clear in teal.osprey:
@gogonzo gogonzo added the core label Jul 1, 2022
@gogonzo gogonzo mentioned this issue Jul 4, 2022
Closed
@pawelru pawelru mentioned this issue Feb 22, 2023
Merged
pawelru added a commit to insightsengineering/teal.gallery that referenced this issue Feb 28, 2023
@pawelru @gogonzo
specify teal minimal version (#12)
b52814e 
an attempt to fix #11

I think the last "global" change was shinyvalidate. I derieved min
versions from linked PRs to
insightsengineering/NEST-roadmap#57. Please
correct me if I missed something.
It's a shortcut solution. More correct would be to implement min version
of teal in tmg and others.

---------

Co-authored-by: Dawid Kałędkowski <[email protected]>
@donyunardi donyunardi mentioned this issue Mar 24, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gogonzo @nikolas-burkoff